-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize Array<Felt252>
return value into output segment
#1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1764 +/- ##
==========================================
- Coverage 94.79% 94.79% -0.01%
==========================================
Files 101 101
Lines 38787 38889 +102
==========================================
+ Hits 36770 36863 +93
- Misses 2017 2026 +9 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
…to-output-segment
fmoletta
changed the title
[WIP] Serialize
[WIP] Serialize May 20, 2024
Array<Felt252>
into output segmentArray<Felt252>
return value into output segment
fmoletta
changed the title
[WIP] Serialize
Serialize May 20, 2024
Array<Felt252>
return value into output segmentArray<Felt252>
return value into output segment
fmoletta
requested review from
igaray,
Oppen,
juanbono and
pefontana
as code owners
May 20, 2024 21:24
juanbono
reviewed
May 22, 2024
juanbono
reviewed
May 22, 2024
juanbono
approved these changes
May 22, 2024
…m/lambdaclass/cairo-vm into serialize-array-to-output-segment
pefontana
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PanicResult<Array<Felt252>>
orArray<Felt252>
can be returned by the program when running with either--proof_mode
or--append_return_values
.PanicResult<Array<Felt252>>
-> [panic_flag, array_len, arr[0], arr[1],.., arr[n]]t<Array<Felt252>
-> [array_len, arr[0], arr[1],.., arr[n]]