Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused dependencies #1307

Merged
merged 3 commits into from Jul 3, 2023
Merged

chore: remove unused dependencies #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7c7b20
Remove unused dependencies
MegaRedHand Jun 30, 2023
4ae3e70
Update changelog
MegaRedHand Jun 30, 2023
be12f76
Merge branch 'main' into remove-unused-deps
MegaRedHand Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -2,6 +2,11 @@

#### Upcoming Changes

* chore: remove unused dependencies [#1307](https://github.com/lambdaclass/cairo-vm/pull/1307)
* rand_core
* serde_bytes
* rusty-hook (*dev-dependency*)

#### [0.8.1] - 2023-6-29

* chore: change mentions of *cairo-rs-py* to *cairo-vm-py* [#1296](https://github.com/lambdaclass/cairo-vm/pull/1296)
Expand Down
75 changes: 1 addition & 74 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 1 addition & 10 deletions Cargo.toml
View file
Open in desktop
@@ -1,10 +1,5 @@
[workspace]
members = [
"cairo-vm-cli",
"felt",
"vm",
"hint_accountant",
]
members = ["cairo-vm-cli", "felt", "vm", "hint_accountant"]
exclude = ["ensure-no_std"]

[workspace.package]
Expand All @@ -28,9 +23,6 @@ rand = { version = "0.8.3", features = ["small_rng"], default-features = false }
num-traits = { version = "0.2", default-features = false }
num-integer = { version = "0.1.45", default-features = false }
serde = { version = "1.0", features = ["derive"], default-features = false }
serde_bytes = { version = "0.11.9", default-features = false, features = [
"alloc",
] }
serde_json = { version = "1.0", features = [
"arbitrary_precision",
"alloc",
Expand All @@ -44,7 +36,6 @@ starknet-crypto = { version = "0.5.0", default-features = false, features = [
"alloc",
] }
sha3 = { version = "0.10.1", default-features = false }
rand_core = { version = "0.6.4", default-features = false }
lazy_static = { version = "1.4.0", default-features = false, features = [
"spin_no_std",
] }
Expand Down
1 change: 1 addition & 0 deletions felt/src/lib_bigint_felt.rs
View file
Open in desktop
Expand Up @@ -1438,6 +1438,7 @@ mod test {

let p_felt = Felt252::max_value();

#[allow(deprecated)]
let modpow = x.modpow(&y, &p_felt).to_biguint();
prop_assert!(modpow < p, "{}", modpow);
}
Expand Down
13 changes: 6 additions & 7 deletions vm/Cargo.toml
View file
Open in desktop
Expand Up @@ -12,18 +12,20 @@ default = ["std", "with_mimalloc"]
with_mimalloc = ["mimalloc"]
std = [
"serde_json/std",
"serde_bytes/std",
"bincode/std",
"anyhow/std",
"starknet-crypto/std",
"felt/std",
"dep:num-prime",
"thiserror-no-std/std",
]
cairo-1-hints = ["dep:cairo-lang-starknet", "dep:cairo-lang-casm", "dep:ark-ff", "dep:ark-std"]
lambdaworks-felt = [
"felt/lambdaworks-felt"
cairo-1-hints = [
"dep:cairo-lang-starknet",
"dep:cairo-lang-casm",
"dep:ark-ff",
"dep:ark-std",
]
lambdaworks-felt = ["felt/lambdaworks-felt"]

# Note that these features are not retro-compatible with the cairo Python VM.
test_utils = [
Expand All @@ -40,13 +42,11 @@ rand = { workspace = true }
num-traits = { workspace = true }
num-integer = { workspace = true }
serde = { workspace = true }
serde_bytes = { workspace = true }
serde_json = { workspace = true }
hex = { workspace = true }
bincode = { workspace = true }
starknet-crypto = { workspace = true }
sha3 = { workspace = true }
rand_core = { workspace = true }
lazy_static = { workspace = true }
nom = { workspace = true }
sha2 = { workspace = true }
Expand Down Expand Up @@ -79,7 +79,6 @@ wasm-bindgen-test = "0.3.34"

[target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies]
iai-callgrind = "0.3.1"
rusty-hook = "0.11"
criterion = { version = "0.3", features = ["html_reports"] }
proptest = "1.0.0"

Expand Down