Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename cairo-rs-py to cairo-vm-py #1296

Merged
merged 7 commits into from Jun 29, 2023
Merged

chore: rename cairo-rs-py to cairo-vm-py #1296

merged 7 commits into from Jun 29, 2023

Conversation

MegaRedHand
Copy link
Contributor

Description

This PR changes cairo-rs-py mentions to cairo-vm-py. Also formats the spec a bit.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@MegaRedHand MegaRedHand marked this pull request as ready for review June 29, 2023 13:45
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1296 (05c8f90) into main (5568d61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          89       89           
  Lines       35471    35471           
=======================================
  Hits        34727    34727           
  Misses        744      744           
Impacted Files Coverage Δ
vm/src/vm/runners/cairo_runner.rs 97.91% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.267 ± 0.008 11.258 11.284 1.00
head blake2s_integration_benchmark 11.300 ± 0.065 11.240 11.414 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.984 ± 0.007 3.973 4.001 1.00
head compare_arrays_200000 3.985 ± 0.014 3.970 4.008 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.638 ± 0.008 2.623 2.650 1.00 ± 0.00
head dict_integration_benchmark 2.631 ± 0.008 2.614 2.639 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.252 ± 0.012 4.238 4.272 1.00
head factorial_multirun 4.263 ± 0.018 4.243 4.299 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.665 ± 0.016 3.649 3.697 1.00
head fibonacci_1000_multirun 3.666 ± 0.013 3.649 3.687 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.962 ± 0.004 1.957 1.972 1.00
head field_arithmetic_get_square_benchmark 1.965 ± 0.012 1.957 1.995 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.072 ± 0.047 10.037 10.196 1.00
head integration_builtins 10.082 ± 0.062 10.025 10.224 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.413 ± 0.041 11.365 11.501 1.00
head keccak_integration_benchmark 11.495 ± 0.137 11.389 11.857 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.984 ± 0.023 3.965 4.042 1.00
head linear_search 4.020 ± 0.037 3.982 4.088 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.865 ± 0.015 2.850 2.890 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.863 ± 0.016 2.848 2.897 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.604 ± 0.023 2.590 2.666 1.01 ± 0.01
head math_integration_benchmark 2.586 ± 0.023 2.567 2.641 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.285 ± 0.015 2.267 2.317 1.00
head memory_integration_benchmark 2.287 ± 0.014 2.268 2.311 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.538 ± 0.011 2.526 2.562 1.00
head operations_with_data_structures_benchmarks 2.540 ± 0.009 2.527 2.555 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 858.2 ± 2.6 855.4 863.4 1.00 ± 0.00
head pedersen 855.1 ± 1.6 853.3 858.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.568 ± 0.006 1.559 1.575 1.00
head poseidon_integration_benchmark 1.571 ± 0.009 1.563 1.597 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.039 ± 0.014 3.025 3.070 1.00 ± 0.00
head secp_integration_benchmark 3.029 ± 0.005 3.018 3.034 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.679 ± 0.003 1.673 1.682 1.00
head set_integration_benchmark 1.681 ± 0.025 1.668 1.748 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.272 ± 0.018 7.249 7.305 1.00 ± 0.00
head uint256_integration_benchmark 7.271 ± 0.011 7.262 7.299 1.00

@pefontana pefontana enabled auto-merge June 29, 2023 20:59
@pefontana pefontana added this pull request to the merge queue Jun 29, 2023
@pefontana pefontana removed this pull request from the merge queue due to a manual request Jun 29, 2023
@pefontana pefontana added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 9b72878 Jun 29, 2023
34 checks passed
@pefontana pefontana deleted the rename-cairo-rs-py branch June 29, 2023 22:21
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Rename cairo-rs-py to cairo-vm-py

* Update changelog

* Run debian install as default user

* Revert "Run debian install as default user"

This reverts commit 64925ac.

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Rename cairo-rs-py to cairo-vm-py

* Update changelog

* Run debian install as default user

* Revert "Run debian install as default user"

This reverts commit 64925ac.

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Rename cairo-rs-py to cairo-vm-py

* Update changelog

* Run debian install as default user

* Revert "Run debian install as default user"

This reverts commit 64925ac.

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Rename cairo-rs-py to cairo-vm-py

* Update changelog

* Run debian install as default user

* Revert "Run debian install as default user"

This reverts commit 64925ac.

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants