Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use LambdaWorks' implementation of bit operations #1291

Merged
merged 3 commits into from Jun 28, 2023
Merged

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Jun 27, 2023

Description

Since some of these implementations were moved upstream, we can just use them.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1291 (6abd177) into main (9ba3c6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          90       90           
  Lines       36260    36260           
=======================================
  Hits        35377    35377           
  Misses        883      883           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.131 ± 0.025 11.109 11.176 1.00
head blake2s_integration_benchmark 11.161 ± 0.039 11.114 11.224 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.875 ± 0.007 3.865 3.885 1.00
head compare_arrays_200000 3.893 ± 0.012 3.877 3.913 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.583 ± 0.011 2.568 2.602 1.01 ± 0.01
head dict_integration_benchmark 2.570 ± 0.009 2.562 2.594 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.148 ± 0.010 4.137 4.171 1.00
head factorial_multirun 4.158 ± 0.023 4.140 4.221 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.539 ± 0.009 3.527 3.558 1.00 ± 0.00
head fibonacci_1000_multirun 3.530 ± 0.003 3.525 3.535 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.921 ± 0.006 1.912 1.930 1.00
head field_arithmetic_get_square_benchmark 1.925 ± 0.012 1.915 1.948 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.949 ± 0.047 9.915 10.068 1.00
head integration_builtins 9.954 ± 0.023 9.925 9.987 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.304 ± 0.064 11.228 11.450 1.00 ± 0.01
head keccak_integration_benchmark 11.294 ± 0.034 11.244 11.365 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.883 ± 0.019 3.864 3.921 1.00
head linear_search 3.900 ± 0.021 3.877 3.927 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.791 ± 0.010 2.781 2.814 1.00 ± 0.00
head math_cmp_and_pow_integration_benchmark 2.783 ± 0.008 2.775 2.801 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.537 ± 0.008 2.523 2.549 1.00 ± 0.00
head math_integration_benchmark 2.531 ± 0.006 2.520 2.541 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.206 ± 0.005 2.199 2.215 1.00
head memory_integration_benchmark 2.217 ± 0.005 2.211 2.224 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.479 ± 0.006 2.472 2.491 1.00 ± 0.00
head operations_with_data_structures_benchmarks 2.478 ± 0.006 2.470 2.489 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 848.3 ± 3.7 846.3 858.8 1.00
head pedersen 848.7 ± 1.9 846.1 851.9 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.539 ± 0.007 1.531 1.557 1.00
head poseidon_integration_benchmark 1.540 ± 0.004 1.535 1.548 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.953 ± 0.006 2.948 2.965 1.00 ± 0.00
head secp_integration_benchmark 2.945 ± 0.005 2.938 2.954 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.499 ± 0.002 1.496 1.501 1.00 ± 0.00
head set_integration_benchmark 1.497 ± 0.003 1.494 1.504 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.175 ± 0.042 7.141 7.244 1.00
head uint256_integration_benchmark 7.183 ± 0.028 7.161 7.252 1.00 ± 0.01

@Oppen Oppen added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit b7725bb Jun 28, 2023
34 checks passed
@Oppen Oppen deleted the simplify-bitops branch June 28, 2023 03:51
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
…#1291)

* Use lambdaworks' implementation of bit operations

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
…#1291)

* Use lambdaworks' implementation of bit operations

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
…#1291)

* Use lambdaworks' implementation of bit operations

* Update changelog
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
…#1291)

* Use lambdaworks' implementation of bit operations

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants