Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cairo-rs to cairo-vm #1289

Merged
merged 6 commits into from Jun 29, 2023
Merged

Rename cairo-rs to cairo-vm #1289

merged 6 commits into from Jun 29, 2023

Conversation

pefontana
Copy link
Member

Rename cairo-rs to cairo-vm

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@@ -67,11 +67,11 @@ Notes
Notes
- Learn to use wasm tooling
- Learn how to compile python to wasm
- Definir the interfaces between the embedded wasm vm and cairo-rs
- Definir the interfaces between the embedded wasm vm and cairo-vm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeje
done

README.md Outdated

A faster and safer implementation of the Cairo VM in Rust

[Report Bug](https://github.com/lambdaclass/cairo-rs/issues/new?labels=bug&title=bug%3A+) · [Request Feature](https://github.com/lambdaclass/cairo-rs/issues/new?labels=enhancement&title=feat%3A+)
[Report Bug](https://github.com/lambdaclass/cairo-vm/issues/new?labels=bug&title=bug%3A+) · [Request Feature](https://github.com/lambdaclass/cairo-vm/issues/new?labels=enhancement&title=feat%3A+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this link to use the bug issue template:

https://github.com/lambdaclass/cairo-vm/issues/new?assignees=&labels=bug&projects=&template=bug_report.md&title=bug%3A+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!
done

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1289 (863e6c0) into main (66658ea) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
+ Coverage   97.57%   97.90%   +0.32%     
==========================================
  Files          92       89       -3     
  Lines       37475    35471    -2004     
==========================================
- Hits        36566    34727    -1839     
+ Misses        909      744     -165     
Impacted Files Coverage Δ
vm/src/types/program.rs 99.47% <ø> (ø)
vm/src/vm/runners/builtin_runner/mod.rs 99.37% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 13.920 ± 0.121 13.772 14.226 1.00 ± 0.01
head blake2s_integration_benchmark 13.901 ± 0.137 13.795 14.209 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.720 ± 0.018 4.694 4.753 1.00
head compare_arrays_200000 4.752 ± 0.045 4.709 4.864 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.114 ± 0.012 3.098 3.136 1.00 ± 0.01
head dict_integration_benchmark 3.109 ± 0.018 3.080 3.137 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.077 ± 0.027 5.031 5.127 1.00
head factorial_multirun 5.081 ± 0.022 5.048 5.119 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.395 ± 0.044 4.340 4.492 1.00
head fibonacci_1000_multirun 4.491 ± 0.063 4.426 4.600 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.334 ± 0.029 2.288 2.382 1.03 ± 0.02
head field_arithmetic_get_square_benchmark 2.272 ± 0.018 2.246 2.306 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 12.537 ± 0.309 12.329 13.405 1.01 ± 0.03
head integration_builtins 12.468 ± 0.120 12.259 12.667 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 14.273 ± 0.174 14.034 14.552 1.01 ± 0.02
head keccak_integration_benchmark 14.164 ± 0.142 13.974 14.494 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.784 ± 0.094 4.699 5.034 1.00 ± 0.02
head linear_search 4.761 ± 0.026 4.721 4.815 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.334 ± 0.026 3.298 3.368 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 3.312 ± 0.015 3.291 3.343 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.068 ± 0.019 3.041 3.098 1.00
head math_integration_benchmark 3.073 ± 0.021 3.052 3.123 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.722 ± 0.022 2.697 2.754 1.00
head memory_integration_benchmark 2.726 ± 0.034 2.674 2.785 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.974 ± 0.025 2.948 3.031 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.971 ± 0.022 2.937 2.997 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.067 ± 0.024 1.051 1.132 1.01 ± 0.02
head pedersen 1.057 ± 0.008 1.045 1.073 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.901 ± 0.010 1.884 1.915 1.00 ± 0.01
head poseidon_integration_benchmark 1.900 ± 0.014 1.879 1.926 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.718 ± 0.024 3.688 3.764 1.01 ± 0.01
head secp_integration_benchmark 3.697 ± 0.015 3.682 3.730 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.012 ± 0.026 1.974 2.052 1.00
head set_integration_benchmark 2.022 ± 0.024 1.993 2.063 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.712 ± 0.178 8.514 9.002 1.01 ± 0.02
head uint256_integration_benchmark 8.595 ± 0.070 8.496 8.697 1.00

@MegaRedHand
Copy link
Contributor

MegaRedHand commented Jun 29, 2023

Should we mention this change in the changelog?

@Oppen
Copy link
Member

Oppen commented Jun 29, 2023

Should we mention this change in the changelog?

Maybe. Since some users point to specific revisions, this is probably true. In general, tho, you'd refer to the crate on crates.io, which has always been cairo-vm.

@pefontana pefontana enabled auto-merge June 29, 2023 18:30
vm/Cargo.toml Outdated Show resolved Hide resolved
@pefontana
Copy link
Member Author

Should we mention this change in the changelog?

Maybe. Since some users point to specific revisions, this is probably true. In general, tho, you'd refer to the crate on crates.io, which has always been cairo-vm.

I can add it :why-not

@pefontana pefontana added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 3ad2613 Jun 29, 2023
34 checks passed
@pefontana pefontana deleted the rename-cairo-rs-to-cairo-vm branch June 29, 2023 20:08
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Rename cairo-rs to cairo-vm

* Rename cairo-rs-py to cairo-vm

* corrections

* Add line to changelog

* typo
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Rename cairo-rs to cairo-vm

* Rename cairo-rs-py to cairo-vm

* corrections

* Add line to changelog

* typo
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Rename cairo-rs to cairo-vm

* Rename cairo-rs-py to cairo-vm

* corrections

* Add line to changelog

* typo
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Rename cairo-rs to cairo-vm

* Rename cairo-rs-py to cairo-vm

* corrections

* Add line to changelog

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants