Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Introduce our custom-built linux-aarch64 wheels for black and mypy #1558

Merged
merged 1 commit into from Sep 9, 2023
Merged

ci: Introduce our custom-built linux-aarch64 wheels for black and mypy #1558

merged 1 commit into from Sep 9, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Sep 9, 2023 •
edited

This doubles the performance of black and mypy in Linux aarch64 development setups by introducing mypyc-based builds.
Note that x86-64 and macOS setups have already been using the mypyc-based builds.

Benchmark:

  • mypy src: 32.18s → 9.99s (with cleaning up .mypy_cache on each run)
  • black --check src: 21.14s → 13.54s

References:

TMI:

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@achimnol achimnol added this to the 23.03 milestone Sep 9, 2023
@achimnol achimnol added area:infrastructure Infrastructure-related issues area:upstream Issues with root cause from upstream 3rd parties skip:changelog Make the action workflow to skip towncrier check type:enhance Enhance component, behavior, internals without user-facing features impact:invisible This change is invisible to users (internal changes). labels Sep 9, 2023
@achimnol achimnol self-assigned this Sep 9, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Sep 9, 2023
@achimnol achimnol added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit 87a3b10 Sep 9, 2023
46 of 53 checks passed
@achimnol achimnol deleted the ci/introduce-faster-mypy-and-black branch September 9, 2023 07:30
achimnol added a commit that referenced this pull request Sep 9, 2023
@achimnol
ci: Introduce our custom-built linux-aarch64 wheels for black and mypy (
738b747 
#1558)

Backported-from: main
Backported-to: 23.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achimnol achimnol

Labels
area:infrastructure Infrastructure-related issues area:upstream Issues with root cause from upstream 3rd parties impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check type:enhance Enhance component, behavior, internals without user-facing features
Projects
None yet
Milestone
23.03
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@achimnol