Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update redis-py requirement from ~= 4.3.4 to ~=4.5.5 #1217

Merged
merged 6 commits into from
May 9, 2023

Conversation

Yaminyam
Copy link
Member

@inureyes
Copy link
Member

@Yaminyam Why kernel runner is changed together?

Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why jail is changed together? Please let me know.

@inureyes inureyes added this to the 22.09 milestone Apr 10, 2023
@Yaminyam
Copy link
Member Author

@inureyes its my mistake.
If I recently created a new branch, the diff of the jail image is detected even though I haven't made any changes.
If this phenomenon disappears, I think the mistake can be prevented. Do you have any idea what the cause might be?

@Yaminyam
Copy link
Member Author

I thought it was a problem that could be solved simply by upgrading the version, but it seems that the changes in redis-py affect while upgrading the version.
There is a part where the test fails, so I think it needs to be resolved.

@Yaminyam Yaminyam added status:help wanted Extra attention is needed. size:M 30~100 LoC labels Apr 10, 2023
@achimnol achimnol marked this pull request as draft April 14, 2023 12:21
@achimnol achimnol added skip:changelog Make the action workflow to skip towncrier check area:upstream Issues with root cause from upstream 3rd parties type:maintenance Maintenance issue. impact:invisible This change is invisible to users (internal changes). labels Apr 17, 2023
@achimnol achimnol changed the title chore: update redis-py requirement from ~= 4.3.4 to ~=4.4.4 chore: update redis-py requirement from ~= 4.3.4 to ~=4.5.4 Apr 17, 2023
@achimnol
Copy link
Member

I think the test failure may be related to #1211, as updating external dependencies only does not trigger Pants to run test cases transitively affected by those dependencies.

@Yaminyam Yaminyam removed the size/S label Apr 19, 2023
@achimnol achimnol added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label May 2, 2023
@kyujin-cho
Copy link
Member

Seems like there's a regression after redis/redis-py#2671 is merged. Delaying merge until the issue is resolved.

@kyujin-cho kyujin-cho removed the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label May 4, 2023
@achimnol achimnol added the action:on hold Hold it. Wait for the restart. label May 6, 2023
@achimnol
Copy link
Member

achimnol commented May 9, 2023

https://github.com/redis/redis-py/releases/tag/v4.5.5 is out 18 hours ago.
Let's try this version.

@achimnol achimnol changed the title chore: update redis-py requirement from ~= 4.3.4 to ~=4.5.4 chore: update redis-py requirement from ~= 4.3.4 to ~=4.5.5 May 9, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label May 9, 2023
@github-actions github-actions bot removed the size:M 30~100 LoC label May 9, 2023
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels May 9, 2023
@achimnol achimnol marked this pull request as ready for review May 9, 2023 06:10
@achimnol achimnol removed the action:on hold Hold it. Wait for the restart. label May 9, 2023
@achimnol
Copy link
Member

achimnol commented May 9, 2023

Now it passes the test suite again!

@achimnol achimnol added this pull request to the merge queue May 9, 2023
@achimnol achimnol removed this pull request from the merge queue due to a manual request May 9, 2023
@achimnol achimnol added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit f55cddc May 9, 2023
32 checks passed
@achimnol achimnol deleted the chore/redis-py-update branch May 9, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:upstream Issues with root cause from upstream 3rd parties impact:invisible This change is invisible to users (internal changes). size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check status:help wanted Extra attention is needed. type:maintenance Maintenance issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants