Fix documentation build by pinning sphinx #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx recently updated all path from string to pathlib, but some plugins we use are not yet updated.
PicoCentauri
requested changes
Aug 21, 2023
| @@ -1,4 +1,4 @@ | |||
| sphinx >=4.4 | |||
| sphinx ==7.1.2 | |||
There was a problem hiding this comment.
to be consistent with rascaline
Suggested change
| sphinx ==7.1.2 | |
| sphinx < 7.2 # breathe is not compatible with sphinx 7.2 yet |
There was a problem hiding this comment.
I tried this first, but it gives me error with furo (it seems to resolve to sphinx 6.2 which also fails)
There was a problem hiding this comment.
not sure why rascaline is not failing ...
There was a problem hiding this comment.
okay very nice! lets go for it.
PicoCentauri
approved these changes
Aug 21, 2023
| @@ -1,4 +1,4 @@ | |||
| sphinx >=4.4 | |||
| sphinx ==7.1.2 | |||
There was a problem hiding this comment.
okay very nice! lets go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx recently updated all path from string to pathlib, but some plugins we use are not yet updated.
We are hitting breathe-doc/breathe#943 and pradyunsg/furo#693 for other versions of sphinx.
馃摎 Documentation preview 馃摎: https://equistore--325.org.readthedocs.build/en/325/