Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v3.2.4 #337

Merged
merged 2 commits into from Jan 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 3.2.2 -> 3.2.4 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.2.4

Compare Source

diff

Fix incorrect parser inference (#​15947 by @​fisker)

Files like .eslintrc.json were incorrectly formatted as JSONC files.

// Input
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "jsonc" }

// Prettier 3.2.4
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "json" }

v3.2.3

Compare Source

diff

Throw errors for invalid code (#​15881 by @​fisker, @​Josh-Cena, @​auvred)
// Input
1++;

// Prettier 3.2.2
1++;

// Prettier 3.2.3
SyntaxError: Invalid left-hand side expression in unary operation (1:1)
> 1 | 1++;
    | ^
// Input
try {} catch (error = 1){}

// Prettier 3.2.2
try {
} catch (error) {}

// Prettier 3.2.3
SyntaxError: Catch clause variable cannot have an initializer. (1:23)
> 1 | try {} catch (error = 1){}
    |                       ^
Fix parser inference (#​15927 by @​fisker)
// Prettier 3.2.2
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "json" }

// Prettier 3.2.3
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "jsonc" }

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@la3rence
Copy link
Owner

prettier/prettier#15927

Error log:

Cannot read config file: ~/site/.eslintrc.json
Error: Expected double-quoted property name in JSON at position 158 (line 6 column 3)

This default behavior of the prettier changed the JSON file with new default JSONC rule:

// Prettier 3.2.2
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "json" }

// Prettier 3.2.3
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "jsonc" }

.eslintrc.json will fail when linter executed.

/label bug
/label wip
/label do-not-merge

@k8s-ci-bot k8s-ci-bot added bug Something isn't working do-not-merge wip labels Jan 18, 2024
@la3rence
Copy link
Owner

la3rence commented Jan 18, 2024

/update

prettier/prettier#15945 new patch seems aim to fix this issue.

@renovate renovate bot changed the title chore(deps): update dependency prettier to v3.2.3 chore(deps): update dependency prettier to v3.2.4 Jan 18, 2024
@la3rence la3rence marked this pull request as ready for review January 18, 2024 13:24
@la3rence
Copy link
Owner

/un-label bug /un-label do-not-merge /un-label wip
/label fixed
/lgtm /approve

@k8s-ci-bot k8s-ci-bot added fixed and removed bug Something isn't working do-not-merge wip labels Jan 18, 2024
@k8s-ci-bot k8s-ci-bot merged commit 0fd735d into main Jan 18, 2024
4 checks passed
@k8s-ci-bot
Copy link
Collaborator

PR #337 was merged (with rebase). Thanks for your contribution.

@delete-merged-branch delete-merged-branch bot deleted the renovate/prettier-3.x branch January 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants