Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

fix(#1691/#1692): remove dep to codelyzer #1697

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

l-lin
Copy link
Owner

@l-lin l-lin commented Dec 10, 2022

Should fix the issue on #1691 and #1692 as the codelyzer depends on angular 9, which may conflict with the project angular version.

@l-lin l-lin requested a review from shanmukhateja December 10, 2022 17:51
@l-lin l-lin force-pushed the fix/1691/remove_codelyzer_dependency branch from 0428ff1 to fd257be Compare December 10, 2022 17:54
Copy link
Collaborator

@shanmukhateja shanmukhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Just hope it still builds and unit tests pass 😅

@l-lin l-lin changed the title fix(#1691): remove dep to codelyzer fix(#1691/#1692): remove dep to codelyzer Dec 10, 2022
@shanmukhateja
Copy link
Collaborator

@l-lin can you make a new release once this is merged? I was thinking of a silent patch release (14.0.1).

We also need to upgrade the library v15. I have been busy past few weeks balancing personal and work lives.

@l-lin
Copy link
Owner Author

l-lin commented Dec 10, 2022

Unfortunately, I already released a v14.0.1 to test the nodejs bump in the github action. I will deprecate this 14.0.1 and release a 14.0.2.

@shanmukhateja
Copy link
Collaborator

Sure, that works. Thanks for looking into this.

@l-lin l-lin merged commit 50ab7c8 into master Dec 13, 2022
@l-lin l-lin deleted the fix/1691/remove_codelyzer_dependency branch December 13, 2022 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants