Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): replaces axios with fetch #368

Merged

Conversation

kleinfreund
Copy link
Contributor

@kleinfreund kleinfreund commented Aug 26, 2022

Replaces axios with fetch for all API interactions.

Removes the manual resolution for tough-cookie which was added because of salesforce/tough-cookie#246. Since that issue was now resolved, this is no longer needed.

Fixes #363.

Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

Philipp Rudloff added 2 commits August 26, 2022 08:59
Replaces axios with fetch for all API interactions.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Removes the manual resolution for tough-cookie which was added because of salesforce/tough-cookie#246. Since that issue was now resolved, this is no longer needed.

Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
@kleinfreund kleinfreund requested a review from a team as a code owner August 26, 2022 07:03
@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit c135e49
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/63087056b3fc640008d26882
😎 Deploy Preview https://deploy-preview-368--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kleinfreund kleinfreund changed the title Refactor/replaces axios with fetch refactor(deps): replaces axios with fetch Aug 26, 2022
@kleinfreund kleinfreund marked this pull request as draft August 26, 2022 07:04
@kleinfreund kleinfreund removed the request for review from a team August 26, 2022 07:04
@kleinfreund kleinfreund self-assigned this Aug 26, 2022
@bartsmykla
Copy link
Contributor

Great job! Preview works on Firefox already :-D

Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kleinfreund kleinfreund marked this pull request as ready for review August 26, 2022 08:45
@kleinfreund kleinfreund requested a review from a team August 26, 2022 08:45
@kleinfreund kleinfreund merged commit 4775df9 into kumahq:master Aug 26, 2022
@kleinfreund kleinfreund deleted the refactor/replaces-axios-with-fetch branch August 26, 2022 08:51
@kleinfreund kleinfreund removed their assignment Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify previews don't work on Firefox
2 participants