馃悰 Update controller gen #1918
馃悰 Update controller gen #1918
Conversation
This is the latest that does not require a higher Kube release than 1.28. Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
This is needed to work with go 1.22, but scares me because the release notes talk about depending on Kubernetes release 1.29. Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
kcp-ci-bot
added
dco-signoff: yes
|
@MikeSpreitzer a safer way to handle this would be to temporarily add Line 254 in 5ed89b1 i.e. -> This could be removed once operator-framework/operator-sdk#6651 is completed & a newer version of operator sdk is released :) |
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
kcp-ci-bot
added
size/S
|
Thanks, @Neo2308 , I have taken your suggestion. |
|
/cc @pdettori |
kcp-ci-bot
requested review from
ezrasilvera,
nirrozenbaum,
pdettori and
waltforme
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ezrasilvera The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 069ae8862ac096cbdf5b28dd4faedbdcdfadf1c9
|
kcp-ci-bot
added
the
approved
Summary
This PR updates the version of controller-tools used, to 0.14.0. This fixes issue #1917 , while controller-tools release 0.13.0 does not. This is a little scary because https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.14.0 says "鈿狅笍 Bump k8s deps to v0.29.0 by @Neo2308 in kubernetes-sigs/controller-tools#872". But the generated files seem to be working.
Related issue(s)
Fixes #1917