Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cluster-api kubekins-e2e version for periodics-main (v20230406-23cb1879e3-1.26 - v20230406-23cb1879e3-1.27) #29314

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Upgrade cluster-api kubekins-e2e version for periodics-main (v20230406-23cb1879e3-1.26 - v20230406-23cb1879e3-1.27) #29314

merged 1 commit into from
Apr 23, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Apr 17, 2023 •
edited

@Prajyot-Parab
Upgrade cluster-api kubekins-e2e version for periodics-main (v2023040…
c43852c 
…6-23cb1879e3-1.26 - v20230406-23cb1879e3-1.27)

Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 17, 2023
@Prajyot-Parab
Copy link
Contributor Author

/cc @sbueringer

@Prajyot-Parab Prajyot-Parab mentioned this pull request Apr 17, 2023
Closed
12 tasks
furkatgofurov7
furkatgofurov7 reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prajyot-Parab thanks for the PR, looks good, the only nit:

Can you please update the PR description with: Part of #link-to-cluster-api-umbrella-issue to cross reference it easier? Thanks!

/lgtm
/hold (wait until presubmit jobs PR: #29313 is merged and make sure it is working as expected before taking this in)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2023
@sbueringer
Copy link
Member

Thx!

Should be fine (xref: kubernetes-sigs/cluster-api#8320 (comment))

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7e17134 into kubernetes:master Apr 23, 2023
4 of 5 checks passed
@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@detiber detiber Awaiting requested review from detiber

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Prajyot-Parab @sbueringer @k8s-ci-robot @furkatgofurov7