Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sigs.k8s.io/bom to v0.6.0 and drop build for linux/s390x and windows/386 #3530

Merged
merged 3 commits into from Apr 2, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 30, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Update sigs.k8s.io/bom to v0.6.0 and drop build for linux/s390x and windows/386

/assign @puerco @xmudrii @saschagrunert
cc @kubernetes/release-managers

from: #3419 (comment)

mmgrf the test is failing because `modernc.org/sqlite` which gets pulled in from the rpmdb module bom is using does not work in windows/386, not even when bumping it to the latest version :(

image

https://gitlab.com/cznic/sqlite/-/issues/169

So we are dropping the windows/386 because of lack of support and also for linux/s390x which maybe we dont have any release managers using that platform

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update sigs.k8s.io/bom to v0.6.0 and drop build for linux/s390x and windows/386

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 31, 2024

opened an issue for the deps review job to figure out what is going on: actions/dependency-review-action#736

but this is a non-blocking job so we can merge that

/assign @puerco @xmudrii

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

hack/verify-build.sh Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Apr 1, 2024

/override dependency-review

@k8s-ci-robot
Copy link
Contributor

@cpanato: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • dependency-review

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • pull-release-integration-test
  • pull-release-test
  • pull-release-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override dependency-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Apr 1, 2024

/skip

@saschagrunert
Copy link
Member

@cpanato should we merge manually here?

@cpanato
Copy link
Member Author

cpanato commented Apr 2, 2024

@cpanato should we merge manually here?

i think so, lets do that

@cpanato cpanato merged commit 0c522db into kubernetes:master Apr 2, 2024
8 of 10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Apr 2, 2024
@cpanato cpanato deleted the update-bom-drop-win-386 branch April 2, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants