Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller-tools: update admins and maintainer group #4169

Merged
merged 1 commit into from
Jun 26, 2023
Merged

controller-tools: update admins and maintainer group #4169

merged 1 commit into from
Jun 26, 2023

Conversation

vincepri
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@alvaroaleman
Copy link
Member

/assign @chaodaiG

@sbueringer
Copy link
Member

/assign @lavalamp

@sbueringer
Copy link
Member

/assign @fedebongio

@sbueringer
Copy link
Member

/assign @deads2k

camilamacedo86
camilamacedo86 approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Hi @deads2k,

How are you? I hope that you are fine.
Could you please look at this one when you have time?

vincepri
vincepri commented May 18, 2023
View reviewed changes
config/kubernetes-sigs/sig-api-machinery/teams.yaml
Comment on lines -62 to -64
- DirectXMan12
- droot
- pwittrock
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These folks have moved to emeritus a while back: https://github.com/kubernetes-sigs/controller-runtime/blob/260b822e9daa53b2ddec007ec48359e38a3ef797/OWNERS_ALIASES#L39-L41

vincepri
vincepri commented May 18, 2023
View reviewed changes
config/kubernetes-sigs/sig-api-machinery/teams.yaml
- pwittrock
- seans3
privacy: closed
controller-tools-contributors:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group was removed given that effectively doesn't provide any value, and it doesn't seem referenced anywhere

fedebongio
fedebongio reviewed May 19, 2023
View reviewed changes
config/kubernetes-sigs/sig-api-machinery/teams.yaml
- joelanford
- mengqiy
- pwittrock
- seans3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sean (seans3) is planning to get involved again shortly (he actually stepped down from SIG CLI). Please keep seans3 for now.
I had the same concern about removing Camila but saw her response too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ptal

Copy link
Member Author

@vincepri vincepri May 19, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also opened a PR in the repository to add @seans3 as maintainer and (edit: doing this separately) add the old maintainers to emeritus, which I missed the first time we cleaned things up kubernetes-sigs/controller-tools#817

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@alvaroaleman @sbueringer @joelanford

ptal to confirm these changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedebongio As far as I can tell Sean doesn't have any contributions to controller-tools as of now (according to devstats).

While we are definitely happy over any new contributors, I would have assumed that usually folks are going through the contribution ladder (https://github.com/kubernetes/community/blob/master/community-membership.md) before gaining maintainer privileges (including approve & write access to the repository).

Apologies if I'm missing something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #4239 as a follow-up once Sean starts contributing to the project.

@fedebongio ptal

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@seans3
Copy link
Contributor

seans3 commented May 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@vincepri
controller-tools: update admins and maintainer group
66f3101 
Signed-off-by: Vince Prignano <vincepri@redhat.com>
@vincepri vincepri mentioned this pull request May 19, 2023
Closed
@fedebongio
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@mrbobbytables
Copy link
Member

/hold cancel
/approve
(approver has lgtmed above)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, camilamacedo86, chaodaiG, mrbobbytables, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 172a430 into kubernetes:main Jun 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedebongio fedebongio fedebongio left review comments

@sbueringer sbueringer sbueringer left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@deads2k deads2k deads2k left review comments

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@chaodaiG chaodaiG chaodaiG approved these changes

Assignees

@lavalamp lavalamp

@fedebongio fedebongio

@sbueringer sbueringer

@seans3 seans3

@camilamacedo86 camilamacedo86

@deads2k deads2k

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet