-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump klog to v2.120.0 #122706
Merged
Merged
bump klog to v2.120.0 #122706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
Denotes a PR that doesn't merit a release note.
label
Jan 11, 2024
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
labels
Jan 11, 2024
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
Issues or PRs related to dependency changes
area/kube-proxy
area/kubectl
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/architecture
Categorizes an issue or PR as relevant to SIG Architecture.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
sig/instrumentation
Categorizes an issue or PR as relevant to SIG Instrumentation.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/storage
Categorizes an issue or PR as relevant to SIG Storage.
and removed
do-not-merge/needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Jan 11, 2024
kaisoz
approved these changes
Jan 11, 2024
/lgtm Thanks @pacoxu |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jan 11, 2024
LGTM label has been added. Git tree hash: 82fd37bee2b45f00583bc23a41eb868ef0086e9c
|
/assign @deads2k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!!
/lgtm |
/approve |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 11, 2024
/triage accepted |
k8s-ci-robot
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
Issues or PRs related to dependency changes
area/kube-proxy
area/kubectl
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note-none
Denotes a PR that doesn't merit a release note.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/architecture
Categorizes an issue or PR as relevant to SIG Architecture.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/cli
Categorizes an issue or PR as relevant to SIG CLI.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/cluster-lifecycle
Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
sig/instrumentation
Categorizes an issue or PR as relevant to SIG Instrumentation.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/storage
Categorizes an issue or PR as relevant to SIG Storage.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121554 is waiting for this bump to use the new added Add SafePtr wrapper by @kaisoz to avoid
panic log
in job controller./kind cleanup
See https://github.com/kubernetes/klog/releases/tag/v2.120.0
/assign @dims
/cc @kaisoz @alculquicondor