Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dependencies] update prometheus/client_golang v1.16.0 to v1.18.0 #122551

Closed
wants to merge 1 commit into from
Closed

[dependencies] update prometheus/client_golang v1.16.0 to v1.18.0 #122551

wants to merge 1 commit into from

Conversation

ty-dc
Copy link
Member

@ty-dc ty-dc commented Jan 2, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates prometheus/client_golang v1.16.0 to v1.18.0

Which issue(s) this PR fixes:
Fixes # None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

update prometheus/client_golang v1.16.0 to v1.18.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 2, 2024
@ty-dc
Copy link
Member Author

ty-dc commented Jan 2, 2024

/sig instrumentation

@ty-dc
Copy link
Member Author

ty-dc commented Jan 2, 2024

/test pull-kubernetes-unit

@alexzielenski
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

@alexzielenski: Those labels are not set on the issue: sig/api-machinery

In response to this:

/remove-sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch 3 times, most recently from 28bdc63 to 3fb566f Compare January 15, 2024 07:09
@bart0sh
Copy link
Contributor

bart0sh commented Jan 18, 2024

/priority important-longterm
/cc @liggitt

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Jan 18, 2024
@bart0sh bart0sh moved this from Needs Approver to Needs Reviewer in SIG Node PR Triage Jan 18, 2024
liggitt
liggitt reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mechanical changes look good, one question about the new CreatedTimestamp field and whether we need to do anything with it or if just ignoring it is correct

staging/src/k8s.io/component-base/metrics/testutil/metrics_test.go Outdated
@@ -585,7 +585,7 @@ func TestGetHistogramVecFromGatherer(t *testing.T) {
vec.WithLabelValues("value1-1", "value2-1").Observe(4.5)
metricName := fmt.Sprintf("%s_%s_%s", HistogramOpts.Namespace, HistogramOpts.Subsystem, HistogramOpts.Name)
histogramVec, _ := GetHistogramVecFromGatherer(gather, metricName, tt.lvMap)
if diff := cmp.Diff(tt.wantVec, histogramVec, cmpopts.IgnoreFields(dto.Histogram{}, "state", "sizeCache", "unknownFields"), cmpopts.IgnoreFields(dto.Bucket{}, "state", "sizeCache", "unknownFields")); diff != "" {
if diff := cmp.Diff(tt.wantVec, histogramVec, cmpopts.IgnoreFields(dto.Histogram{}, "state", "sizeCache", "unknownFields", "CreatedTimestamp"), cmpopts.IgnoreFields(dto.Bucket{}, "state", "sizeCache", "unknownFields")); diff != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the meaning of the new CreatedTimestamp field, and are there any implications for our lazy initialization of metrics? cc @logicalhan

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ty-dc please address this review comment and rebase the PR, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. this should be a new feature introduced in v1.17.0.

I should not ignore the creation time, but when doing the comparison the following error will appear

    --- FAIL: TestGetHistogramVecFromGatherer/filter_with_one_label (0.00s)
        metrics_test.go:595: Got unexpected HistogramVec (-want +got):
              testutil.HistogramVec{
                &{
                        Histogram: &io_prometheus_client.Histogram{
                                ... // 3 ignored and 2 identical fields
                                SampleSum: &1.5,
                                Bucket:    {&{CumulativeCount: &0, UpperBound: &0.5}, &{CumulativeCount: &1, UpperBound: &2}, &{CumulativeCount: &1, UpperBound: &5}},
                                CreatedTimestamp: &timestamppb.Timestamp{
                                        ... // 3 ignored fields
                                        Seconds: 1706235962,
            -                           Nanos:   318936000,
            +                           Nanos:   319122000,
                                },
                                Schema:        nil,
                                ZeroThreshold: nil,
                                ... // 8 identical fields
                        },
                },

I tried ignoring "CreatedTimestamp.Nanos", Is it okay to do this? Can you give me some advice? thanks.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch from 3fb566f to 9eb7459 Compare January 24, 2024 05:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch from 9eb7459 to fefee46 Compare January 24, 2024 06:04
@ty-dc
Copy link
Member Author

ty-dc commented Jan 24, 2024

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2024
@bart0sh bart0sh moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Jan 25, 2024
@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch from fefee46 to 622c72e Compare January 26, 2024 02:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch 2 times, most recently from 0c08de0 to 12cbaaa Compare January 26, 2024 02:53
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@ty-dc
[dependencies] update prometheus/client_golang v1.16.0 to v1.18.0
7cecc49 
Signed-off-by: tao.yang <tao.yang@daocloud.io>
@ty-dc ty-dc force-pushed the update-prometheus-client_golang branch from 12cbaaa to 7cecc49 Compare February 26, 2024 07:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ty-dc
Once this PR has been reviewed and has the lgtm label, please assign liggitt, sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ty-dc
Copy link
Member Author

ty-dc commented Feb 28, 2024

Out of date, a new version has been released.

https://github.com/prometheus/client_golang/releases/tag/v1.19.0

@ty-dc ty-dc closed this Feb 28, 2024
SIG Node PR Triage automation moved this from Waiting on Author to Done Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees

@logicalhan logicalhan

Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ty-dc @alexzielenski @k8s-ci-robot @dashpole @bart0sh @liggitt @logicalhan