Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Enable CRD field dropping for validation ratcheting #122329

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Bug fix: Enable CRD field dropping for validation ratcheting #122329

merged 1 commit into from
Dec 15, 2023

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Dec 15, 2023 •
edited

/kind bug
/kind api-change

What this PR does / why we need it:

CRD field dropping was added to CRD validation ratcheting and carefully unit tested, but never got fully wired in.

Which issue(s) this PR fixes:

Special notes for your reviewer:

This should be cherry picked to 1.29 (#121034 was introduced in 1.29)

Does this PR introduce a user-facing change?

Fixes accidental enablement of the new alpha `optionalOldSelf` API field in CustomResourceDefinition validation rules, which should only be allowed to be set when the CRDValidationRatcheting feature gate is enabled.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2023
@jpbetz jpbetz changed the title Wire in field dropping for CRDs Bug fix: Enable CRD field dropping for validation ratcheting Dec 15, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2023

cc @alexzielenski

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2023

/retest

@liggitt
Copy link
Member

liggitt commented Dec 15, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df711fa0422d1eefc7de451ba7d652c668e64236

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2023 •
edited

/priority critically-urgent

@k8s-ci-robot
Copy link
Contributor

@jpbetz: The label(s) priority/critially-urgent cannot be applied, because the repository doesn't have them.

In response to this:

/priority critially-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2023

/triage accepted
/priority critically-urgent

@k8s-ci-robot
Copy link
Contributor

@jpbetz: The label(s) priority/critically-urgent cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/priority critically-urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 15, 2023

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2023
@jpbetz jpbetz mentioned this pull request Dec 15, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 4cff5e8 into kubernetes:master Dec 15, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 15, 2023
k8s-ci-robot added a commit that referenced this pull request Dec 21, 2023
@k8s-ci-robot
Merge pull request #122343 from jpbetz/automated-cherry-pick-of-#1223…
4e50a91 
…29-origin-release-1.29

Automated cherry pick of #122329: Wire in field dropping for CRDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpbetz @liggitt @k8s-ci-robot