Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API comment for the Job ready field #121765

Merged
merged 1 commit into from Nov 7, 2023
Merged

Fix API comment for the Job ready field #121765

merged 1 commit into from Nov 7, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Nov 6, 2023 •
edited

What type of PR is this?

/kind documentation
/kind api-change

What this PR does / why we need it:

Fixes the comment after graduation to GA.

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#2879

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix API comment for the Job Ready field in status

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2879-ready-pods-job-status

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Nov 6, 2023

/assign @alculquicondor @deads2k

liggitt
liggitt reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a63882173f3183035e90d4a5f8da29bc17059106

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2023
@kannon92
Copy link
Contributor

kannon92 commented Nov 7, 2023

needs a label for 1.29 if we want it in this release.

@liggitt can you add a milestone to this?

@liggitt
Copy link
Member

liggitt commented Nov 7, 2023

/milestone v1.29

doc-only change reflecting field state in 1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit e4b74dd into kubernetes:master Nov 7, 2023
14 checks passed
@mimowo mimowo deleted the ready-pods-stable-api branch November 29, 2023 15:00
@alculquicondor alculquicondor mentioned this pull request Jan 4, 2024
Open
@hahewlet hahewlet mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mimowo @k8s-ci-robot @alexzielenski @kannon92 @liggitt @alculquicondor @deads2k