Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate BackoffLimitPerIndex to Beta #121356

Merged
merged 2 commits into from Oct 23, 2023
Merged

Graduate BackoffLimitPerIndex to Beta #121356

merged 2 commits into from Oct 23, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 19, 2023 •
edited

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of: kubernetes/enhancements#3850

Special notes for your reviewer:

Graduation criteria from KEP:

Benchmark results: #121393.

Does this PR introduce a user-facing change?

Graduate Job BackoffLimitPerIndex feature to Beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 19, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 19, 2023

/sig apps
/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 19, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 19, 2023

/test pull-kubernetes-linter-hints

tenzen-y
tenzen-y reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you probably need to mention kubernetes/enhancements#3850, not #3850 in the description.

staging/src/k8s.io/api/batch/v1/types.go Outdated Show resolved Hide resolved
@mimowo @tenzen-y
Update staging/src/k8s.io/api/batch/v1/types.go
9be1b68 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kannon92
kannon92 reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d5755174edd6620f307ffa59678ea10ec38420e

@kannon92
Copy link
Contributor

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Oct 19, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 19, 2023

/test pull-kubernetes-e2e-gce
unrelated test failure

@mimowo
Copy link
Contributor Author

mimowo commented Oct 19, 2023

/assign @deads2k
Who reviewed the KEP and API for Alpha.

@deads2k
Copy link
Contributor

deads2k commented Oct 19, 2023

Once the beta criteria are complete, this looks good.

To the question of an e2e test, that can be done in a separate PR that builds on top of this one to demonstrate that it works prior to promotion.

@jensentanlo jensentanlo mentioned this pull request Oct 19, 2023
Open
8 tasks
@Jefftree
Copy link
Member

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 19, 2023
@mimowo mimowo mentioned this pull request Oct 19, 2023
Merged
alculquicondor
alculquicondor reviewed Oct 19, 2023
View reviewed changes
staging/src/k8s.io/api/batch/v1/types.go
Comment on lines +550 to +553
// https://kep.k8s.io/3850
JobReasonMaxFailedIndexesExceeded string = "MaxFailedIndexesExceeded"
// JobReasonFailedIndexes means Job has failed indexes.
JobReasonFailedIndexes string = "FailedIndexes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicate that they are beta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that once I noticed lgtm :) Opened small cleanup: #121471.

alculquicondor
alculquicondor reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, conditional to the metrics and E2E PRs

@alculquicondor
Copy link
Member

The metrics PR is in the merge queue #121292

The E2E test LGTM #121368

/approve
/assign @deads2k

@deads2k
Copy link
Contributor

deads2k commented Oct 23, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, deads2k, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8149ab3 into kubernetes:master Oct 23, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 23, 2023
@mimowo mimowo mentioned this pull request Oct 24, 2023
Merged
@mimowo mimowo deleted the backoff-limit-per-index-beta branch November 29, 2023 15:00
@BBBmau BBBmau mentioned this pull request Jan 12, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kannon92 kannon92 kannon92 left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@atiratree atiratree Awaiting requested review from atiratree

@dims dims Awaiting requested review from dims

Assignees

@alculquicondor alculquicondor

@kannon92 kannon92

@deads2k deads2k

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.29
SIG Apps
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mimowo @k8s-ci-robot @kannon92 @deads2k @Jefftree @alculquicondor @tenzen-y