Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4210: add support for ImageMaximumGCAge field #121275

Merged
merged 7 commits into from Oct 25, 2023
Merged

KEP-4210: add support for ImageMaximumGCAge field #121275

merged 7 commits into from Oct 25, 2023

Conversation

haircommander
Copy link
Contributor

@haircommander haircommander commented Oct 16, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds support for ImageGCMaximumAge kubelet configuration field, which sets the maximum age of an image before it's deemed unused and worthy of garbage collecting.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add ImageMaximumGCAge field to Kubelet configuration, which allows a user to set the maximum age an image is unused before it's garbage collected.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 16, 2023
@haircommander haircommander changed the title KEP-4210: add support for ImageGCMaximumAge field KEP-4210: add support for ImageMaximumGCAge field Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2023
@haircommander
kubelet/images: refactor freeImage and imagesInEvictionOrder
e22ebf1 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
kubelet/images: refactor image gc unit tests
28f335a 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 16, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Oct 17, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 17, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 17, 2023
liggitt
liggitt reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API bits lgtm. One nit on the field doc.

Once this has lgtm / approve for non API packages tag me and I'll add approve for the API config field package

pkg/kubelet/apis/config/types.go Outdated
// garbage collected.
ImageMinimumGCAge metav1.Duration
// ImageMaximumGCAge is the maximum age an image can be unused before it is garbage collected.
// The default of this field is "0s", which disables it.
Copy link
Member

@liggitt liggitt Oct 20, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess "which disables it" could be read two ways – does it disable GC or mean there is no max age? make that clearer in the doc (here and in v1beta1/types.go)

@haircommander
kubelet: add and use ImageMaximumGCAge in KubeletConfiguration
d992ea4 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
kubelet config validation: add validation for image max gc age
76e6230 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
kubelet/images: add and use freeOldImages function
914aa74 
to free images older than configured ImageGCMaximumAge

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
kubelet/images: add unit test for MaxAge
d8a5cd5 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
metrics: add and use ImageGarbageCollectedTotal
49c947b 
to help find MaxAge thresholds and detect image addition/removal thrashing

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@kannon92
Copy link
Contributor

kannon92 commented Oct 24, 2023 •
edited

/lgtm

/assign @dchen1107 @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67f667dd609370c45c3896583482a502494d6d58

@kannon92
Copy link
Contributor

/assign @mrunalp @dchen1107

@mrunalp
Copy link
Contributor

mrunalp commented Oct 25, 2023

/approve

@liggitt
Copy link
Member

liggitt commented Oct 25, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, liggitt, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@kannon92 kannon92 mentioned this pull request Oct 25, 2023
Open
8 tasks
@k8s-ci-robot k8s-ci-robot merged commit 12b01af into kubernetes:master Oct 25, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 25, 2023
@acumino acumino mentioned this pull request Dec 21, 2023
Open
16 tasks
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 4, 2024
@jrvaldes
[nodeconfig] Add ImageMaximumGCAge to Kubelet configuration
b477e25 
Add ImageMaximumGCAge field to Kubelet configuration for consistency with
the unit test payload. kubernetes/kubernetes#121275
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 5, 2024
@jrvaldes
[nodeconfig] Add ImageMaximumGCAge to kubeconfig
886877b 
Add ImageMaximumGCAge field to Kubelet configuration for consistency with
the unit test payload. kubernetes/kubernetes#121275
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 9, 2024
@jrvaldes
[nodeconfig] Add ImageMaximumGCAge test payload
6bba89a 
See kubernetes/kubernetes#121275
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 9, 2024
@jrvaldes
[nodeconfig] Add ImageMaximumGCAge to kubelet conf
82a237b 
See kubernetes/kubernetes#121275
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 9, 2024
@jrvaldes
[nodeconfig] Adjust kubelet conf in unit test
64c49c8 
Add ImageMaximumGCAge with default value to kubelet conf
in the unit test spec.
See kubernetes/kubernetes#121275
jrvaldes added a commit to jrvaldes/windows-machine-config-operator that referenced this pull request Jan 17, 2024
@jrvaldes
[nodeconfig] Adjust kubelet conf in unit test
414f6c3 
Add ImageMaximumGCAge with default value to kubelet conf
in the unit test spec.
See kubernetes/kubernetes#121275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@kannon92 kannon92 kannon92 left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@rphillips rphillips

@mrunalp mrunalp

@kannon92 kannon92

@dchen1107 dchen1107

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.29
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@haircommander @bart0sh @kannon92 @k8s-ci-robot @mrunalp @liggitt @rphillips @dchen1107