New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-3085] Promote PodReadyToStartContainers to beta in 1.29 #119659
[KEP-3085] Promote PodReadyToStartContainers to beta in 1.29 #119659
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 16:11:31 UTC 2023. |
543bc89
to
c66ae4b
Compare
Just putting this up as its fresh in my head what is required for this KEP for 1.29. |
c66ae4b
to
01f4d72
Compare
01f4d72
to
c67ff58
Compare
/retest |
1 similar comment
/retest |
/triage accepted Please raise this with SIG node to ensure that this work is tracked for 1.29. 1.29 planning hasn't started yet but there is likely to be a discussion soon. Keep an eye on the SIG node agenda doc and the planning doc. |
/lgtm |
LGTM label has been added. Git tree hash: f0c2140a8bc8b2802135236f21ac5881fc5bb938
|
a475b0c
to
c94240e
Compare
API constant lgtm, ping me when the feature and kubelet packages have node owner approval and I'll add |
/lgtm |
LGTM label has been added. Git tree hash: 582e34779ae8a698cd06e78846f2950726d129e3
|
/test unit looks like a flake |
@rphillips: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubernetes-unit |
@liggitt when you get a chance, can you give final approval? It looks like we have all the necessary ones now. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, liggitt, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As part of the beta promotion for PodReadyToStartContainers (KEP 3085), we need to move the API from a kubelet constant to a api versioned condition.
This also changes the feature gate to beta and cleans up some deprecation in the pod_conditions_test.go
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: