Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume resource requirements #118653

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Volume resource requirements #118653

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. api: introduce separate VolumeResourceRequirements struct 

    PVC and containers shared the same ResourceRequirements struct to define their
API. When resource claims were added, that struct got extended, which
accidentally also changed the PVC API. To avoid such a mistake from happening
again, PVC now uses its own VolumeResourceRequirements struct.

The `Claims` field gets removed because risk of breaking someone is low:
theoretically, YAML files which have a claims field for volumes now
get rejected when validating against the OpenAPI. Such files
have never made sense and should be fixed.

Code that uses the struct definitions needs to be updated.
    @pohly
    pohly committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2472291 View commit details
    Browse the repository at this point in the history

  2. generated files

    @pohly
    pohly committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c1eb18c View commit details
    Browse the repository at this point in the history