Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/emicklei/go-restful/v3 to v3.10.2 #115067

Closed
wants to merge 1 commit into from
Closed

Bump github.com/emicklei/go-restful/v3 to v3.10.2 #115067

wants to merge 1 commit into from

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jan 13, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bumps github.com/emicklei/go-restful/v3 from v3.9.0 to v3.10.2

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lucacome. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2023
@lucacome lucacome mentioned this pull request Jan 13, 2023
Closed
@k8s-ci-robot k8s-ci-robot requested review from apelisse, cheftako and a team January 13, 2023 20:00
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2023
@apelisse
Copy link
Member

/assign @Jefftree
Do you want to look at that Jeff?

@dims
Copy link
Member

dims commented Jan 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 14, 2023
@lucacome
Bump github.com/emicklei/go-restful/v3 to v3.10.2
da16a33 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lucacome
Once this PR has been reviewed and has the lgtm label, please assign deads2k, dims, sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Mar 10, 2023

/assign @liggitt

@k8s-ci-robot
Copy link
Contributor

@lucacome: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-100-performance 2ed77e2c2d05fe9c47f04b43513d2ccda708614c link true /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-node-e2e-containerd da16a33 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-conformance-kind-ga-only-parallel da16a33 link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-e2e-kind-kms da16a33 link false /test pull-kubernetes-e2e-kind-kms
pull-kubernetes-e2e-kind-ipv6 da16a33 link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-unit da16a33 link true /test pull-kubernetes-unit
pull-kubernetes-e2e-kind da16a33 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce da16a33 link true /test pull-kubernetes-e2e-gce
pull-kubernetes-verify da16a33 link true /test pull-kubernetes-verify
pull-kubernetes-integration da16a33 link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

liggitt
liggitt reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still looks like it's producing diffs in generated openapi paths (pull-kubernetes-verify is failing with diffs in the openapi produced by the server)

pkg/kubelet/cri/streaming/server.go
Comment on lines +369 to +373
var (
_ remotecommandserver.Executor = &criAdapter{}
_ remotecommandserver.Attacher = &criAdapter{}
_ portforward.PortForwarder = &criAdapter{}
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem related, suggest dropping it from this PR

staging/src/k8s.io/apiserver/pkg/endpoints/discovery/group.go
@@ -52,7 +53,7 @@ func NewAPIGroupHandler(serializer runtime.NegotiatedSerializer, group metav1.AP
func (s *APIGroupHandler) WebService() *restful.WebService {
mediaTypes, _ := negotiation.MediaTypesForSerializer(s.serializer)
ws := new(restful.WebService)
ws.Path(APIGroupPrefix + "/" + s.group.Name)
ws.Path(path.Join(APIGroupPrefix, s.group.Name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? what was this doing differently previously?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrueg mrueg mentioned this pull request May 1, 2023
Merged
@saschagrunert saschagrunert mentioned this pull request May 5, 2023
Closed
This was referenced May 16, 2023
Closed
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2023
@liggitt liggitt mentioned this pull request Jul 12, 2023
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 13, 2023
@RamakrishnanArun RamakrishnanArun mentioned this pull request Jul 28, 2023
Closed
@rexagod
Copy link
Member

rexagod commented Aug 4, 2023

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Aug 4, 2023
This was referenced Aug 11, 2023
Merged
Closed
Closed
@liggitt
Copy link
Member

liggitt commented Aug 11, 2023

/close

in favor of #119865 which is rebased

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

in favor of #119865 which is rebased

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Waiting on Author to Done Aug 11, 2023
@lucacome lucacome deleted the bump-go-restful branch August 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@apelisse apelisse Awaiting requested review from apelisse

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

@Jefftree Jefftree

Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Archived in project
[sig-architecture] Dependency management
Status: Done
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@lucacome @k8s-ci-robot @apelisse @dims @Jefftree @cici37 @liggitt @bart0sh @k8s-triage-robot @rexagod