Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump prometheus/common library #2352

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Mar 27, 2024

What this PR does / why we need it:
In later releases of prometheus/common FormatStrings got unexported to allow to check for more permutations with other features encoded in the contentType.
prometheus/common#576

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2024
@knabben
Copy link
Member

knabben commented Apr 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3478fe9 into kubernetes:main Apr 2, 2024
12 checks passed
@mrueg
Copy link
Member Author

mrueg commented Apr 2, 2024

/lgtm

@knabben
I noticed that you haven't been involved in this project, so this lgtm feels very drive-by-ish.
Would you like to become more involved with the project?

@knabben
Copy link
Member

knabben commented Apr 2, 2024

@mrueg It was for a specific case; I apologize if you were expecting other assigned reviewers.

I'm not sure if I have the bandwidth to collaborate on the project actively.

@mrueg
Copy link
Member Author

mrueg commented Apr 2, 2024

@knabben Yes, the expectation in general is that contributors would lgtm pull requests and not unrelated members of the kubernetes org (and if they do it, then they would usually provide some context why).

Was there any specific bug or issue that you saw that this PR fixes?

@shuguet
Copy link

shuguet commented Apr 5, 2024

Sorry folks, I reached out on the CNCF Ambassador channel to ask if there was any maintainer of this project present who could approved this, as our (internal) project includes some modules from this repo, and we were blocked (importing 2 modules of different versions, the usual).

I did not mean to cause any issue here 🙏

Thank you for merging this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants