-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change/ingress-nginx hardening and upgrade to v1.10.0 #11012
base: master
Are you sure you want to change the base?
Conversation
change/add metrics to ingress-nginx service bump/ingress-nginx version v1.10.0
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrxmvtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @chrxmvtik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @chrxmvtik
Thanks for the PR. Please add information about the changes to the release note also consider bumping up the version in the README here: https://github.com/kubernetes-sigs/kubespray/blob/master/README.md?plain=1#L181
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Does this PR introduce a user-facing change?: