Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix internal layout: move main.go boilerplate to cmd/ directory #4246

Merged

Conversation

camilamacedo86
Copy link
Member

Moves main.go boilerplate to the cmd/ directory to align the project structure with scaffolded templates, ensuring consistency and maintainability.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024

Verified

This commit was signed with the committer’s verified signature.
phillebaba Philip Laine
Moves main.go boilerplate to the cmd/ directory to align the project structure with scaffolded templates, ensuring consistency and maintainability.
@camilamacedo86 camilamacedo86 changed the title 🌱 Improve maintainability by aligning internal layout: move main.go boilerplate to cmd/ directory 🐛 fix internal layout: move main.go boilerplate to cmd/ directory Oct 29, 2024
@camilamacedo86
Copy link
Member Author

We are here just ensuring that the code implementation is aligned with the structure of the projects which are scaffolded
So, I will move forward since it is a very small nit.
We have a lot of PRs for reviews and I will not make people waste time on this one.
Moving forward.

@camilamacedo86 camilamacedo86 merged commit 81ce166 into kubernetes-sigs:master Oct 30, 2024
16 of 18 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-layout-structure branch October 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants