Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add go version to dep cache key #1091

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

jmdeal
Copy link
Member

@jmdeal jmdeal commented Mar 11, 2024

Fixes #N/A

Description
Adds the go version to the dependency cache key. This is to address an issue with govulncheck, where the same version of govulncheck built with 1.21 crashes when run against a 1.22 project: golang/go#65590

How was this change tested?

  • Run against github actions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2024
@jmdeal jmdeal mentioned this pull request Mar 11, 2024
@coveralls
Copy link

coveralls commented Mar 11, 2024

Pull Request Test Coverage Report for Build 8237509747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 81.094%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 95.96%
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 91.53%
Totals Coverage Status
Change from base Build 8206973287: -0.02%
Covered Lines: 8227
Relevant Lines: 10145

💛 - Coveralls

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit c98dda4 into kubernetes-sigs:main Mar 11, 2024
12 checks passed
@jmdeal jmdeal deleted the add-go-cache-key branch May 9, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants