-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds new option timeoutSeconds
to inform the the timeout for webhook resources
#784
Conversation
|
Welcome @yaa110! |
Hi @yaa110. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting. I am OK with this one.
However, can we better address what changes here in the tiltle?
I added a suggestion on it. See that 🌱 is used only for changes that does not affect the end-users.
Otherwise,
/lgtm
@alvaroaleman @vincepri wdyt?
timeoutSeconds
to inform the the timeout for webhook resources
/ok-to-test |
timeoutSeconds
to inform the the timeout for webhook resourcestimeoutSeconds
to inform the the timeout for webhook resources
timeoutSeconds
to inform the the timeout for webhook resourcestimeoutSeconds
to inform the the timeout for webhook resources
@camilamacedo86 thank you for reviewing the PR. The commit message has been amended based on your edit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
I am ok with this one 👍
Let's see what others think about
/lgtm
Thank you! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, sbueringer, yaa110 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I needed to change
timeoutSeconds
default value in a project created usingkubebuilder
and I realized that it is not possible to do that. So, I opened this PR.