Merge pull request #829 from rainest/feat/error-duplicate-gen

✨ Return an error for duplicate generators
kubernetes-sigs · Jul 11, 2023 · 9378a61 · 9378a61
2 parents 95ddbaf + 75e6573
commit 9378a61
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/genall/options.go b/pkg/genall/options.go
@@ -136,6 +136,9 @@ func protoFromOptions(optionsRegistry *markers.Registry, options []string) (prot
 		switch val := val.(type) {
 		case Generator:
 			gens = append(gens, &val)
+			if _, alreadyExists := gensByName[defn.Name]; alreadyExists {
+				return protoRuntime{}, fmt.Errorf("multiple instances of '%s' generator specified", defn.Name)
+			}
 			gensByName[defn.Name] = &val
 		case OutputRule:
 			_, genName := splitOutputRuleOption(defn.Name)