[release-0.18] 🐛 Reintroduce AddMetricsServerExtraHandler on manager #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vince Prignano <vince@prigna.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c793af178013ac8f8f76fac0cb2d0b1a7500e196
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
merged commit 834905b
into
kubernetes-sigs:release-0.18
6 of 7 checks passed
renovate bot
added a commit
to registry-operator/registry-operator
that referenced
this pull request
May 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | `v0.18.1` -> `v0.18.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.1...v0.18.2) #### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2817 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.1...v0.18.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/registry-operator/registry-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImFyZWEvZGVwZW5kZW5jeSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to aenix-io/etcd-operator
that referenced
this pull request
May 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | patch | `v4.1.4` -> `v4.1.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/onsi/ginkgo/v2](https://togithub.com/onsi/ginkgo) | require | patch | `v2.17.2` -> `v2.17.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang | stage | patch | `1.22.2` -> `1.22.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [golangci/golangci-lint](https://togithub.com/golangci/golangci-lint) | | patch | `v1.58.0` -> `v1.58.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [hugo-extended](https://togithub.com/jakejarvis/hugo-extended) | devDependencies | patch | [`0.125.4` -> `0.125.6`](https://renovatebot.com/diffs/npm/hugo-extended/0.125.4/0.125.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.18.1` -> `v0.18.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.5`](https://togithub.com/actions/checkout/releases/tag/v4.1.5) [Compare Source](https://togithub.com/actions/checkout/compare/v4.1.4...v4.1.5) #### What's Changed - Update NPM dependencies by [@​cory-miller](https://togithub.com/cory-miller) in [actions/checkout#1703 - Bump github/codeql-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [actions/checkout#1694 - Bump actions/setup-node from 1 to 4 by [@​dependabot](https://togithub.com/dependabot) in [actions/checkout#1696 - Bump actions/upload-artifact from 2 to 4 by [@​dependabot](https://togithub.com/dependabot) in [actions/checkout#1695 - README: Suggest `user.email` to be `41898282+github-actions[bot]@​users.noreply.github.com` by [@​cory-miller](https://togithub.com/cory-miller) in [actions/checkout#1707 **Full Changelog**: actions/checkout@v4.1.4...v4.1.5 </details> <details> <summary>onsi/ginkgo (github.com/onsi/ginkgo/v2)</summary> ### [`v2.17.3`](https://togithub.com/onsi/ginkgo/releases/tag/v2.17.3) [Compare Source](https://togithub.com/onsi/ginkgo/compare/v2.17.2...v2.17.3) #### 2.17.3 ##### Fixes `ginkgo watch` now ignores hidden files \[[`bde6e00`](https://togithub.com/onsi/ginkgo/commit/bde6e00)] </details> <details> <summary>golangci/golangci-lint (golangci/golangci-lint)</summary> ### [`v1.58.1`](https://togithub.com/golangci/golangci-lint/compare/v1.58.0...v1.58.1) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.58.0...v1.58.1) </details> <details> <summary>jakejarvis/hugo-extended (hugo-extended)</summary> ### [`v0.125.6`](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.5...v0.125.6) [Compare Source](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.5...v0.125.6) ### [`v0.125.5`](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.4...v0.125.5) [Compare Source](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.4...v0.125.5) </details> <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.1...v0.18.2) #### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2817 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.1...v0.18.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * 6" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aenix-io/etcd-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJvay10by10ZXN0Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Hidden Marten <hiddenmarten@gmail.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2813
/assign vincepri