Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Make client.MatchingLabels faster #2529

Merged
merged 1 commit into from Oct 9, 2023
Merged

🏃 Make client.MatchingLabels faster #2529

merged 1 commit into from Oct 9, 2023

Commits on Oct 9, 2023

  1. 🏃 Make client.MatchingLabels faster 

    The 99% use-case of this is to set a selector, not to adjust an existing
one. This change introduces a fastpath that does that with half the
allocations and in a bit less than half the time.

The reason slowpath is slow is that for each label a requirement has to
be constructed that is then appended to a slice, both of which cause
allocations.
    @alvaroaleman
    alvaroaleman committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    cb5be1f View commit details
    Browse the repository at this point in the history