Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Handle unstructured status update with fake client #2495

Merged

Commits on Sep 14, 2023

  1. Handle unstructured status update with fake client

    In order to prevent unintentional mutations outside of the status during
    a status update, the non-status fields are copied back onto the passed
    object.
    
    This operation now gracefully handles both unstructured and typed
    objects. Previously, it would panic if an unstructured object was passed
    for a GVK known to the scheme, as internally the object within the
    tracker is converted to the typed equivalent. The two types cannot
    be directly assigned to each other and instead must be copied.
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6860cfb View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Review feedback

    Using typed objects for the initial and actual object content assertion.
    Unstructured objects are only used for the update.
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    42608d3 View commit details
    Browse the repository at this point in the history