Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix status subresource getting updated on Update when it is empty #2484

Merged
merged 1 commit into from Sep 9, 2023

Commits on Sep 9, 2023

  1. 🐛 Fix status subresource getting updated on Update when it is empty

    Before this, Update and Patch requests will override to-level status
    fields for objects that have a status resource if the status was
    initially empty.
    
    This happens because the code to set the status to what we already have
    in the unupdated object converts the object into a `map[string]any`
    using json serialization/deserialization, copies the original `status`
    field, then converts back. The json deserializer unfortunatelly does not
    properly clear the target, allowing data to remain that is absent in the
    json serialization.
    alvaroaleman committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    e368149 View commit details
    Browse the repository at this point in the history