⚠️ Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discovery restmapper was unused except for two places that we missed (when creating a cache directly as opposed through the manager and in a test). The discovery restmapper only ever loads mappings once during startup and is unable to reload them if they change. It also isn't lazy and we don't want anyone using it.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/retest |
|
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vincepri
approved these changes
Dec 6, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle |
k8s-ci-robot
changed the title
|
/lgtm |
tpantelis
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
Jan 24, 2024
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Jan 24, 2024
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to tpantelis/submariner-operator
that referenced
this pull request
Jan 24, 2024
The latter isn't recommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
Jan 24, 2024
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
added a commit
to submariner-io/submariner-operator
that referenced
this pull request
Jan 25, 2024
The latter isn't recommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
4 tasks
Neo2308
added a commit
to Neo2308/ansible-operator-plugins
that referenced
this pull request
May 3, 2024
Use NewDynamicRESTMapper instead of NewDiscoveryRESTMapper (Ref: kubernetes-sigs/controller-runtime#2611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discovery restmapper was unused except for two places that we missed (when creating a cache directly as opposed through the manager and in a test). The discovery restmapper only ever loads mappings once during startup and is unable to reload them if they change. It also isn't lazy and we don't want anyone using it.
Instead, the
DynamicRESTMappershould be used.