New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fix markdown links to flaky pages #8559
📖 Fix markdown links to flaky pages #8559
Conversation
6ea2629
to
e2420af
Compare
Should be cherry-picked back to supported branches. /cherry-pick release-1.3 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 69f2e02622d8bacdd30468e402329a3c29219cc0
|
How does the format influence the flakiness? |
e2420af
to
360b259
Compare
@sbueringer - you're right. I had it in my head that the MDlinks were only checked when they were formatted as markdown links. I've update the PR to use an alternative page which IMO is a good replacement, and the subdomain seems much less flaky) |
Makes sense /lgtm Not sure how to assess if the new pages are fine as well. Stupid question, how important / sustainable is it to have a link to Windows licensing terms in our proposal? Just considering how much time we already spent on those flaky links makes me wonder if it's worth the effort. |
LGTM label has been added. Git tree hash: ee280d4907df0e00e423a7811b9ee143209e91e5
|
I used this to check the link multiple times - ran into the same flake with the original, but nothing with the learn.microsoft.com link. |
@jsturtevant @marosset @dtzar to help answer this |
I think it would be good to keep it. |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
360b259
to
0c2d8e4
Compare
/lgtm |
LGTM label has been added. Git tree hash: 505dcb77df50e8cec4095b16b74bf96f30333977
|
I agree it good to have it mentioned. Is there a way to disable the linter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: new pull request created: #8561 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8562 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Improve the signal of the weekly markdown link checker by changing the format of flaky external links.
Fixes #