Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix markdown links to flaky pages #8559

Merged
merged 1 commit into from Apr 24, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Apr 24, 2023

Improve the signal of the weekly markdown link checker by changing the format of flaky external links.

Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2023
@killianmuldoon
Copy link
Contributor Author

Should be cherry-picked back to supported branches.

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

Should be cherry-picked back to supported branches.

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69f2e02622d8bacdd30468e402329a3c29219cc0

@sbueringer
Copy link
Member

How does the format influence the flakiness?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@killianmuldoon
Copy link
Contributor Author

@sbueringer - you're right. I had it in my head that the MDlinks were only checked when they were formatted as markdown links.

I've update the PR to use an alternative page which IMO is a good replacement, and the subdomain seems much less flaky)

@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023

Makes sense

/lgtm

Not sure how to assess if the new pages are fine as well.

Stupid question, how important / sustainable is it to have a link to Windows licensing terms in our proposal?
(cc @CecileRobertMichon @jackfrancis)

Just considering how much time we already spent on those flaky links makes me wonder if it's worth the effort.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee280d4907df0e00e423a7811b9ee143209e91e5

@killianmuldoon
Copy link
Contributor Author

Not sure how to assess if the new pages are fine as well.

I used this to check the link multiple times - ran into the same flake with the original, but nothing with the learn.microsoft.com link.

@CecileRobertMichon
Copy link
Contributor

Stupid question, how important / sustainable is it to have a link to Windows licensing terms in our proposal?
(cc @CecileRobertMichon @jackfrancis)

Just considering how much time we already spent on those flaky links makes me wonder if it's worth the effort.

@jsturtevant @marosset @dtzar to help answer this

@marosset
Copy link

Stupid question, how important / sustainable is it to have a link to Windows licensing terms in our proposal?
(cc @CecileRobertMichon @jackfrancis)

Just considering how much time we already spent on those flaky links makes me wonder if it's worth the effort.

@jsturtevant @marosset @dtzar to help answer this

I think it would be good to keep it.

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@marosset
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 505dcb77df50e8cec4095b16b74bf96f30333977

@jsturtevant
Copy link
Contributor

I agree it good to have it mentioned. Is there a way to disable the linter?

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc799af into kubernetes-sigs:main Apr 24, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 24, 2023
@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #8561

In response to this:

Should be cherry-picked back to supported branches.

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #8562

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants