-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱Upgrade golang version (1.19.6 -> 1.20.3) #8527
Conversation
/hold |
/retest /test pull-cluster-api-e2e-full-main |
/test pull-cluster-api-apidiff-main |
/test pull-cluster-api-apidiff-main This looks good to me, thanks! |
hmm, seems I can't retrigger the test, might be that only maintainers have the rights to do so, but let's try these too since it was triggered but there was a force push after /test pull-cluster-api-e2e-full-main |
/retest |
There are no limitations regarding triggering jobs (at least if you're an org member) |
/test pull-cluster-api-build-main |
/retest |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 64f8b693e0aec3b02d54d5c1c26bfa849e147479
|
@Prajyot-Parab please add "Part of #8459" to the PR description |
@@ -1,6 +1,6 @@ | |||
run: | |||
timeout: 10m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please also bump:
- go.mod files
In a follow-up:
- cloudbuild.yaml, cloudbuild-nightly.yaml: there is currently no gcb-docker-gcloud image with Go 1.20 => I think that was in test-infra and we can open a PR to bump Go in that image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted.
I would just do it in this PR. Just a bit simpler. I think there is no need to split it into a separate PR. |
That is what I always thought but was not aware the reasoning behind the splitting, thanks for confirming. /cc @Prajyot-Parab (to confirm the answer ^ to your question offline) |
/hold |
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
/retest |
/lgtm /hold |
LGTM label has been added. Git tree hash: f9413ef7e4542c6f54804b896e27e740a0e1200f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest known flake |
/check-cla |
@Prajyot-Parab Can you check if there's anything you have to do / can do regarding the CLA? |
/hold cancel tests are fine |
/easycla |
@sbueringer fixed |
/area dependency |
What this PR does / why we need it:
Seeding is added by default from 1.20 onwards. More info here
Part of #8459
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #