Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Upgrade golang version (1.19.6 -> 1.20.3) #8527

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Apr 14, 2023

What this PR does / why we need it:

  • Upgrade golang version (1.19.6 -> 1.20.3)
  • Fixing golangci-lint error: rand.Seed has been deprecated since Go 1.20.
    Seeding is added by default from 1.20 onwards. More info here

Part of #8459

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2023
@Prajyot-Parab
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@sbueringer
Copy link
Member

/retest

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@sbueringer
Copy link
Member

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-build-main
/test pull-cluster-api-verify-main

@furkatgofurov7
Copy link
Member

/test pull-cluster-api-apidiff-main

This looks good to me, thanks!
@sbueringer do we take care of the go mod bump in a separate PR (as we usual did in the past)?

@furkatgofurov7
Copy link
Member

test pull-cluster-api-apidiff-main

hmm, seems I can't retrigger the test, might be that only maintainers have the rights to do so, but let's try these too since it was triggered but there was a force push after

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023

hmm, seems I can't retrigger the test, might be that only maintainers have the rights to do so, but let's try these too since it was triggered but there was a force push after

There are no limitations regarding triggering jobs (at least if you're an org member)

@sbueringer
Copy link
Member

/test pull-cluster-api-build-main

@furkatgofurov7
Copy link
Member

/retest

@Prajyot-Parab Prajyot-Parab changed the title 🌱[WIP] Upgrade golang version (1.19.6 -> 1.20.3) 🌱Upgrade golang version (1.19.6 -> 1.20.3) Apr 24, 2023
@Prajyot-Parab
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64f8b693e0aec3b02d54d5c1c26bfa849e147479

@sbueringer
Copy link
Member

@Prajyot-Parab please add "Part of #8459" to the PR description

@@ -1,6 +1,6 @@
run:
timeout: 10m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please also bump:

  • go.mod files

In a follow-up:

  • cloudbuild.yaml, cloudbuild-nightly.yaml: there is currently no gcb-docker-gcloud image with Go 1.20 => I think that was in test-infra and we can open a PR to bump Go in that image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

@sbueringer
Copy link
Member

@sbueringer do we take care of the go mod bump in a separate PR (as we usual did in the past)?

I would just do it in this PR. Just a bit simpler. I think there is no need to split it into a separate PR.

@furkatgofurov7
Copy link
Member

@sbueringer do we take care of the go mod bump in a separate PR (as we usual did in the past)?

I would just do it in this PR. Just a bit simpler. I think there is no need to split it into a separate PR.

That is what I always thought but was not aware the reasoning behind the splitting, thanks for confirming.

/cc @Prajyot-Parab (to confirm the answer ^ to your question offline)

@Prajyot-Parab
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@Prajyot-Parab
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
Feel free to remove the hold once all currently running tests are green

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9413ef7e4542c6f54804b896e27e740a0e1200f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@sbueringer
Copy link
Member

/retest

known flake

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2023
@sbueringer
Copy link
Member

/check-cla

@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023

@Prajyot-Parab Can you check if there's anything you have to do / can do regarding the CLA?

@sbueringer
Copy link
Member

/hold cancel

tests are fine

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@furkatgofurov7
Copy link
Member

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 24, 2023
@furkatgofurov7
Copy link
Member

@Prajyot-Parab Can you check if there's anything you have to do / can do regarding the CLA?

@sbueringer fixed

@k8s-ci-robot k8s-ci-robot merged commit 2038804 into kubernetes-sigs:main Apr 24, 2023
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 24, 2023
@johannesfrey
Copy link
Contributor

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants