Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Update versions doc with k8s v1.27 notes #8520

Merged

Conversation

furkatgofurov7
Copy link
Member

Signed-off by: Furkat Gofurov (furkat.gofurov@suse.com)

What this PR does / why we need it:
Updates versions.md with new k8s version v1.27.0 notes

Part of: #8459

cc @kubernetes-sigs/cluster-api-release-team

Signed-off by: Furkat Gofurov (furkat.gofurov@suse.com)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2023
@furkatgofurov7
Copy link
Member Author

/assign @sbueringer

@sbueringer
Copy link
Member

sbueringer commented Apr 13, 2023

/lgtm
/approve

/hold
Up to you if you want to merge now or after the new Jobs are green

Please note: we should also update the doc on the release-1.4 branch to add v1.27 support for v1.4.x
Note sure when, ideally with the next v1.4.x release that actually supports v1.27 (probably also good to mention in the table with which v1.4.x version we started to support v1.27)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d5d67ef2ecb8d9ff69a766f2fad78fe8994e7ff

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@furkatgofurov7
Copy link
Member Author

Up to you if you want to merge now or after the new Jobs are green

I am fine either way, probably let's merge it after jobs are 馃煝

Please note: we should also update the doc on the release-1.4 branch to add v1.27 support for v1.4.x
Note sure when, ideally with the next v1.4.x release that actually supports v1.27 (probably also good to mention in the table with which v1.4.x version we started to support v1.27)

Makes sense, I will make a note of this just to not forget about it.

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furkatgofurov7
Copy link
Member Author

@sbueringer
Copy link
Member

sbueringer commented Apr 14, 2023

Great!

What I'm mostly looking for is green tests on #8518
(as this runs our full e2e test suite against 1.27)

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Apr 17, 2023

Great!

What I'm mostly looking for is green tests on #8518 (as this runs our full e2e test suite against 1.27)

Absolutely, we had already successful run on #8518 but that is a separate topic, on this one new tests look very stable (100% green) after 3 runs. @sbueringer I think we are safe to take this PR in?

@sbueringer
Copy link
Member

Yup feel free to merge

@furkatgofurov7
Copy link
Member Author

Yup feel free to merge

Thx.
We need to put some notes (maybe in umbrella issue) so that we don't forget about back-porting it to next v1.4.x release (probably the one on Tuesday 2nd May 2023) that actually supports v1.27.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit c45667b into kubernetes-sigs:main Apr 17, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 17, 2023
@furkatgofurov7 furkatgofurov7 deleted the update-version-doc-k8s-1-27 branch April 17, 2023 11:44
@furkatgofurov7
Copy link
Member Author

We need to put some notes (maybe in umbrella issue) so that we don't forget about back-porting it to next v1.4.x release (probably the one on Tuesday 2nd May 2023) that actually supports v1.27.

Created a PR (on hold) assuming v1.4.2 will support 1.27, we can see later when new 1.4.x is out and assumption made in #8539 makes sense or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants