Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Ensure nil-pointer check in KCP syncMachines #8481

Merged
merged 1 commit into from Apr 6, 2023
Merged

🐛 Ensure nil-pointer check in KCP syncMachines #8481

merged 1 commit into from Apr 6, 2023

Conversation

killianmuldoon
Copy link
Contributor

Adds a nil-check when retrieving a Kubeconfig for a machine in KCP. This nil-pointer issue was likely introduced in #8057

Fixes #8480

@killianmuldoon
Ensure nil-pointer check in KCP syncMachines
48f1df6 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2023
@killianmuldoon killianmuldoon mentioned this pull request Apr 5, 2023
Closed
@killianmuldoon
Copy link
Contributor Author

/hold

Waiting for reproduction from #8480

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

1 similar comment
@killianmuldoon
Copy link
Contributor Author

/retest

fabriziopandini
fabriziopandini reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f02c6813844ea4395ce31d5ce60b42d3c78662e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@killianmuldoon
Copy link
Contributor Author

/hold cancel

Confirmed to fix the issue #8480

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2023
@fabriziopandini
Copy link
Member

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 4276bb4 into kubernetes-sigs:main Apr 6, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 6, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 6, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #8488

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johannesfrey
Copy link
Contributor

/area provider/control-plane-kubeadm

@k8s-ci-robot k8s-ci-robot added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Stacktrace when replacing imported controlplane
5 participants
@killianmuldoon @k8s-ci-robot @fabriziopandini @k8s-infra-cherrypick-robot @johannesfrey