🌱 Add runtime extension components to release #8438
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
k8s-ci-robot
added
area/release
|
/cherry-pick release-1.4 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d06e3116be3c1926d853955f79941b81e58bf9e2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@killianmuldoon: new pull request created: #8440 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@killianmuldoon Can you provide some context as to why we did this? Was it just to allow users to install the test extension (which is fine) or did we have to do it also for tests? |
|
The context was this mostly: #8430 (review) But it wasn't causing a failing test at the time. I decided to add it to the release artifacts anyway as it makes sense IMO. Will also be useful in future if / when clusterctl upgrade tests include and rely on external patches. |
Add a target to generate manifests for the test runtime extension to the release target.
/area release