Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add support or concurrent MD upgrades in classy clusters #8432

Merged

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Mar 31, 2023

What this PR does / why we need it:

This PR adds support to concurrently upgrade MachineDeployments in Classy Clusters.

The maximum concurrency is defined by setting the topology.cluster.x-k8s.io/upgrade-concurrency annotation on the Cluster. If unspecified a default concurrency of 1 is used (only one MachineDeployment is upgraded at a time).
Example: If the annotation "topology.cluster.x-k8s.io/upgrade-concurrency": "3" is set on the Cluster at most 3 MachineDeployments will be upgraded concurrently.

This upgrade concurrency honors the topology.cluster.x-k8s.io/defer-upgrade and topology.cluster.x-k8s.io/hold-upgrade-sequence annotations applied on the MachineDeploymentTopology and upgrades the qualifying MachineDeployments concurrently.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2023
@ykakarap ykakarap force-pushed the pr-concurrent-worker-upgrades branch from 510d8a9 to bc42715 Compare April 3, 2023 23:52
@ykakarap ykakarap changed the title ✨ [EXPERIMENT][DNR] add support or concurrent MD upgrades ✨ add support or concurrent MD upgrades in classy clusters Apr 3, 2023
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review focusing on the production code change.

Please also add a bit of PR description describing the change

api/v1beta1/common_types.go Outdated Show resolved Hide resolved
internal/webhooks/cluster.go Outdated Show resolved Hide resolved
internal/webhooks/cluster.go Outdated Show resolved Hide resolved
internal/webhooks/cluster.go Outdated Show resolved Hide resolved
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending documentation

api/v1beta1/common_types.go Show resolved Hide resolved
api/v1beta1/common_types.go Outdated Show resolved Hide resolved
api/v1beta1/common_types.go Show resolved Hide resolved
internal/webhooks/cluster.go Show resolved Hide resolved
internal/webhooks/cluster.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the pr-concurrent-worker-upgrades branch from a007658 to 9cbf19e Compare April 12, 2023 19:00
@sbueringer
Copy link
Member

Thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 420fdd50e7d6befae1eab6f647c10de8967ce62f

@fabriziopandini
Copy link
Member

/lgtm
/approve
great work, thanks @ykakarap!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@fabriziopandini
Copy link
Member

As per Wed 12th office hours discussion

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

As per Wed 12th office hours discussion

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 91d645f into kubernetes-sigs:main Apr 14, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 14, 2023
@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #8528

In response to this:

As per Wed 12th office hours discussion

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johannesfrey
Copy link
Contributor

/area clusterclass

@k8s-ci-robot k8s-ci-robot added the area/clusterclass Issues or PRs related to clusterclass label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants