Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Allow backport for experimental features #8293

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Proposing a small amendment to backport policy in order to allow a little bit of more flexibility for experimental features

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I think the two maintainers rule will help to keep this to the minimum necessary changes.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8840ba6ea3576b749cc0344a9c6c33df87ce31a4

@sbueringer
Copy link
Member

/lgtm

Sounds good to me!

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

squash commits?

@elmiko
Copy link
Contributor

elmiko commented Mar 22, 2023

discussed this today in the community meeting, would be nice to start practicing this for our next release. no rush on getting this merged though.

if no objections by next friday, we will merge this.

@sbueringer
Copy link
Member

Not super important but I assume this means next week Friday?

(cc @killianmuldoon @fabriziopandini given recent discussion around this phrase 馃槀)

@fabriziopandini fabriziopandini force-pushed the allow-backport-for-experimental-features branch from 0a40194 to 6f31397 Compare March 23, 2023 13:33
@fabriziopandini
Copy link
Member Author

The lazy consensus deadline expired
/approve
/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

The lazy consensus deadline expired
/approve
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 828c7ea into kubernetes-sigs:main Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 31, 2023
@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #8441

In response to this:

The lazy consensus deadline expired
/approve
/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the allow-backport-for-experimental-features branch May 9, 2023 12:35
@johannesfrey
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Jun 16, 2023
@killianmuldoon
Copy link
Contributor

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Jun 16, 2023
@killianmuldoon killianmuldoon removed the area/release Issues or PRs related to releasing label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants