-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 GitLab can use both Path and RawPath #10608
base: main
Are you sure you want to change the base?
Conversation
Hi @aetertinas9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I apologize for any shortcomings |
/retitle 馃尡 GitLab can use both Path and RawPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Question: You did test this version locally too with a gitlab repository, right?
LGTM label has been added. Git tree hash: ca8335f448e83cd95fa7c2d9e031462ac6e59e09
|
@chrischdi |
What this PR does / why we need it:
#9481
This is a bug that occurred in the above link and has not been resolved for a long time. However, it needs to be included in the release version, so I am opening a new issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10605
/area clusterctlIssues or PRs related to clusterctl
--> area/clusterctl