Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Simplify our backport policy #10583

Merged
merged 1 commit into from
May 29, 2024

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented May 8, 2024

The current rules & regulations are highly restrictive; with past experiences in mind usually is up to maintainers to determine if something can and should be backported. The sole exception is breaking changes which aren't allowed across the board when backporting to released versions.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
@fabriziopandini
Copy link
Member

I'm +1 to simplify rules, it is a way to recognize that more of 60% of contributions in the last year came from 5 top maintainers, and in some respects, it seems that nowadays those rules apply only to the same persons that are defining them (which is overkilling).

Also introducing some flexibility can act as incentive for other folks to contribute, because the time to get the feature in a release can be shortened if maintainers agree on the backport.

I'm just wondering we should keep existing rules as examples / reference instead of dropping them entirely, we put a lot of effort in getting agreement on those in the past

The current rules & regulations are highly restrictive; with past
experiences in mind usually is up to maintainers to determine if
something can and should be backported. The sole exception is breaking
changes which aren't allowed across the board when backporting to
released versions.

Signed-off-by: Vince Prignano <vince@prigna.com>
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da103bcec43919a403f746d2ed5eaf14fb75eacc

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 289658d into kubernetes-sigs:main May 29, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants