-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement controller paused condition for core CAPI resources #10364
base: main
Are you sure you want to change the base?
WIP: Implement controller paused condition for core CAPI resources #10364
Conversation
This change updates the types to add a new PausedCondition. It also adds two reasons: ResourcePausedReason, and ResourceNotPausedReason This is to enable controllers to report when a resource is paused. This allows an administrator to work with confidence on a paused object.
Welcome @theobarberbany! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @theobarberbany. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@theobarberbany PTAL comments on the original issue |
de3bbf5
to
76f5ab0
Compare
f040e82
to
e369071
Compare
/area area/provider/core |
@theobarberbany: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area provider/core |
This change updates the machine controller to set the paused condition based on if the cluster or machine resource is paused.
e369071
to
fe9d5bc
Compare
This change updates the cluster controller to set the paused condition based on if the cluster is paused.
fe9d5bc
to
4544633
Compare
This change updates the machine set controller to set the paused condition based on if the cluster or machine set resource is paused.
4544633
to
588774b
Compare
This change updates the machine health check controller to set the paused condition based on if the cluster or machine health check is paused.
1975743
to
660227d
Compare
This change updates the machine deployment controller to set the paused condition based on if the cluster or machine deployment has the paused annotations.
97d9b36
to
3624ef3
Compare
3624ef3
to
3b20a92
Compare
Waiting on: #10550 in order to update the condition with new polarity. |
What this PR does / why we need it:
This PR Adds the Paused condition, and tests to all of the core CAPI resources.
Fixes #10130
/area area/provider/core