🌱 Add BootstrapFailedMachineError error

[mcbenjemaa]

What this PR does / why we need it:

In some infra providers, we need more configuration to provision a cluster.
For example, cloud-init config and control plane endpoint.

Since there are no validations for those configs, the Bootstrap (cloud-init) may fail due to misconfiguration, and we need to figure out why.

Having a new machine error reason will give clear idea what's happening to users

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area machine

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mcbenjemaa]

/area machine

[mcbenjemaa]

/ok-to-test

[sbueringer]

How do we make sure that users don't confuse this with that the bootstrap provider failed?

(edited)

[enxebre]

@mcbenjemaa this would be very useful. These kind of errors though might happen after the iaas considers an instance started, in which case they are not surfaced/exposed in any immediate consumable way. Can you articulate an example of how such a failure would be detected and bubble up here?

To make sure we approach this holistically and come up with the most valuable approach, we might want to start by writing down some failure scenarios and how they would be surfaced.
FWIW see previous related efforts #2554

[mcbenjemaa]

I'm Using CAPI provider for Proxmox,
And I need a way of detecting if the bootstrap fails.

With Proxmox im calling the API to check the status of cloud-init.

And based on that, will mark a machine as Bootstrap Failed,
So the user knows that it's failing due to the bootstrap data.