Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] ✨ add support or concurrent MD upgrades in classy clusters #8528

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #8432

/assign fabriziopandini

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2023
@sbueringer
Copy link
Member

sbueringer commented Apr 14, 2023

@CecileRobertMichon @enxebre @vincepri @fabriziopandini @killianmuldoon

Hey folks,
as mentioned on Wednesday in the office hours we would like to cherry-pick this change which is an extension of the experimental ClusterClass feature.

Enhancements or additions to experimental Cluster API features, with the goal of allowing faster adoption and iteration; Please note that stability of the branch will always be top priority while evaluating those PRs, and thus approval requires /lgtm from at least two maintainers that, on top of checking that the backport is not introducing any breaking change for either API or behavior, will evaluate if the impact of those backport is limited and well-scoped e.g. by checking that those changes should not touch non-experimental code paths like utils and/or by applying other considerations depending on the specific PR.

  • The change only affects ClusterClass, specifically the logic which calculates when a MachineDeployment is upgraded
  • The default behavior (if the annotation is not set) is the same as before this change. I.e. this change is only active if a user explicitly adds the annotation

Please let us know if you have any objections. We would like to merge the cherry-pick ~ the week after KubeCon so it will be part of the v1.4.2 release.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 772671dfc0fdceccf3a22896a48a32e1924dc2fa

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9fdf507 into kubernetes-sigs:release-1.4 Apr 24, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants