Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab repository: support both the project ID and the escaped full path #10605

Open
aetertinas9 opened this issue May 14, 2024 · 5 comments · May be fixed by #10608
Open

Gitlab repository: support both the project ID and the escaped full path #10605

aetertinas9 opened this issue May 14, 2024 · 5 comments · May be fixed by #10608
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@aetertinas9
Copy link

What steps did you take and what happened?

#9481

This is a bug that occurred in the above link and has not been resolved for a long time. However, it needs to be included in the release version, so I am opening a new issue.

What did you expect to happen?

Using GitLab as per the docs, it supports both the project ID and the escaped full path.

Cluster API version

release version

Kubernetes version

v1.28.4

Anything else you would like to add?

Thanks :)

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aetertinas9 aetertinas9 mentioned this issue May 14, 2024
Closed
@aetertinas9
Copy link
Author

sorry it's my first PR

@aetertinas9 aetertinas9 reopened this May 14, 2024
@aetertinas9 aetertinas9 linked a pull request May 14, 2024 that will close this issue
Open
@fabriziopandini
Copy link
Member

Q: is this issue + related PR a replacement of #9481?
Can we close it?

@aetertinas9
Copy link
Author

@fabriziopandini
That's correct. I also opened this issue because of the same problem with not being able to use the GitLab URL properly. Instead of using the url.Path, this supports both the escaped full path and project ID as per the official documentation.

@fabriziopandini fabriziopandini mentioned this issue May 23, 2024
Closed
@fabriziopandini
Copy link
Member

/priority backlog

I think those kind of errors boils up to the fact that we don't have a good test coverage for all the supported use cases.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
3 participants
@fabriziopandini @k8s-ci-robot @aetertinas9