Ensure nil-pointer check in KCP syncMachines

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
kubernetes-sigs · Apr 6, 2023 · f1cca4b · f1cca4b
1 parent bc2766b
commit f1cca4b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/controlplane/kubeadm/internal/controllers/controller.go b/controlplane/kubeadm/internal/controllers/controller.go
@@ -598,7 +598,10 @@ func (r *KubeadmControlPlaneReconciler) syncMachines(ctx context.Context, contro
 			return errors.Wrapf(err, "failed to update InfrastructureMachine %s", klog.KObj(infraMachine))
 		}
 
-		kubeadmConfig := controlPlane.KubeadmConfigs[machineName]
+		kubeadmConfig, ok := controlPlane.GetKubeadmConfig(machineName)
+		if !ok || kubeadmConfig == nil {
+			return errors.Wrapf(err, "failed to retrieve KubeadmConfig for machine %s", machineName)
+		}
 		// Note: Set the GroupVersionKind because updateExternalObject depends on it.
 		kubeadmConfig.SetGroupVersionKind(m.Spec.Bootstrap.ConfigRef.GroupVersionKind())
 		// Cleanup managed fields of all KubeadmConfigs to drop ownership of labels and annotations