Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-runtime to v0.15.0 #1248

Conversation

flavio-fernandes
Copy link

@flavio-fernandes flavio-fernandes commented Jun 2, 2023

What this PR does / why we need it:

Update controller-runtime to v0.15.0, which is a requirement for using this provider with Kube 1.27.
This is needed since kubernetes-sigs/cluster-api#8007 , which is now based
on that controller-runtime as well.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Part of kubernetes-sigs/cluster-api#8459
Part of https://issues.redhat.com/browse/SDN-3901

Special notes for your reviewer:

/area provider/ibmcloud

 1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update controller-runtime to v0.15.0

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jun 2, 2023
@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 55369a1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/64799befd64e3b0008829baa
😎 Deploy Preview https://deploy-preview-1248--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @flavio-fernandes!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @flavio-fernandes. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavio-fernandes
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2023
@flavio-fernandes
Copy link
Author

Steps taken to update controller-runtime (ie. this PR):

go get -u sigs.k8s.io/controller-runtime && go mod tidy
❯ go get -u sigs.k8s.io/controller-runtime
go: downloading k8s.io/kube-openapi v0.0.0-20230601164746-7562a1006961
go: downloading github.com/google/gnostic-models v0.6.8
go: upgraded github.com/cespare/xxhash/v2 v2.1.2 => v2.2.0
go: upgraded github.com/emicklei/go-restful/v3 v3.9.0 => v3.10.2
go: upgraded github.com/go-logr/logr v1.2.3 => v1.2.4
go: upgraded github.com/go-openapi/jsonpointer v0.19.5 => v0.19.6
go: upgraded github.com/go-openapi/jsonreference v0.20.0 => v0.20.2
go: added github.com/google/gnostic-models v0.6.8
go: upgraded github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38 => v0.0.0-20210720184732-4bb14d4b1be1
go: upgraded github.com/imdario/mergo v0.3.13 => v0.3.16
go: upgraded github.com/matttproud/golang_protobuf_extensions v1.0.2 => v1.0.4
go: upgraded github.com/onsi/ginkgo/v2 v2.9.2 => v2.9.5
go: upgraded github.com/onsi/gomega v1.27.6 => v1.27.7
go: upgraded github.com/prometheus/client_golang v1.14.0 => v1.15.1
go: upgraded github.com/prometheus/client_model v0.3.0 => v0.4.0
go: upgraded github.com/prometheus/common v0.37.0 => v0.44.0
go: upgraded github.com/prometheus/procfs v0.8.0 => v0.10.1
go: upgraded github.com/sirupsen/logrus v1.8.1 => v1.9.0
go: upgraded golang.org/x/oauth2 v0.6.0 => v0.8.0
go: upgraded golang.org/x/tools v0.7.0 => v0.9.1
go: upgraded gomodules.xyz/jsonpatch/v2 v2.2.0 => v2.3.0
go: upgraded google.golang.org/protobuf v1.28.1 => v1.30.0
go: upgraded k8s.io/api v0.26.1 => v0.27.2
go: upgraded k8s.io/apiextensions-apiserver v0.26.1 => v0.27.2
go: upgraded k8s.io/apimachinery v0.26.1 => v0.27.2
go: upgraded k8s.io/apiserver v0.26.1 => v0.27.2
go: upgraded k8s.io/client-go v0.26.1 => v0.27.2
go: upgraded k8s.io/component-base v0.26.1 => v0.27.2
go: upgraded k8s.io/klog/v2 v2.80.1 => v2.100.1
go: upgraded k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280 => v0.0.0-20230601164746-7562a1006961
go: upgraded k8s.io/utils v0.0.0-20221128185143-99ec85e7a448 => v0.0.0-20230505201702-9f6742963106
go: upgraded sigs.k8s.io/controller-runtime v0.14.5 => v0.15.0
go: upgraded sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 => v0.0.0-20221116044647-bc3834ca7abd

❯ go mod tidy
go: finding module for package gotest.tools/v3/skip
go: finding module for package gotest.tools/v3/assert/cmp
go: finding module for package gotest.tools/v3/env
go: finding module for package gotest.tools/v3/assert
go: downloading gotest.tools v2.2.0+incompatible
go: downloading gotest.tools/v3 v3.4.0
go: found gotest.tools/v3/assert in gotest.tools/v3 v3.4.0
go: found gotest.tools/v3/assert/cmp in gotest.tools/v3 v3.4.0
go: found gotest.tools/v3/env in gotest.tools/v3 v3.4.0
go: found gotest.tools/v3/skip in gotest.tools/v3 v3.4.0

@flavio-fernandes
Copy link
Author

/cc @Karthik-K-N

@mkumatag
Copy link
Member

mkumatag commented Jun 2, 2023

Ideally we bump all the versions at once when get a new release of cluster-api project which is pending at the moment and here is the umbrella task created - #1249

cc @Prajyot-Parab

@mkumatag
Copy link
Member

mkumatag commented Jun 2, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@Prajyot-Parab
Copy link
Contributor

Ideally we bump all the versions at once when get a new release of cluster-api project which is pending at the moment and here is the umbrella task created - #1249

cc @Prajyot-Parab

Yes we should wait for new CAPI release (with CR v0.15.0) to be out before we adopt this change, can unhold when that happens.

@flavio-fernandes
Copy link
Author

Ideally we bump all the versions at once when get a new release of cluster-api project which is pending at the moment and here is the umbrella task created - #1249
cc @Prajyot-Parab

Yes we should wait for new CAPI release (with CR v0.15.0) to be out before we adopt this change, can unhold when that happens.

Sounds reasonable. Thank you for the feedback @Prajyot-Parab and @mkumatag!
Feel free to close/change this PR if the proper method for doing this bump is better performed differently.

@mkumatag mkumatag closed this Jun 2, 2023
@flavio-fernandes flavio-fernandes deleted the controller-runtime-update branch June 2, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants