-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller-runtime to v0.15.0 #1248
Update controller-runtime to v0.15.0 #1248
Conversation
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Welcome @flavio-fernandes! |
Hi @flavio-fernandes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavio-fernandes The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Steps taken to update controller-runtime (ie. this PR):
|
/cc @Karthik-K-N |
Ideally we bump all the versions at once when get a new release of cluster-api project which is pending at the moment and here is the umbrella task created - #1249 |
/hold |
Yes we should wait for new CAPI release (with CR v0.15.0) to be out before we adopt this change, can unhold when that happens. |
Sounds reasonable. Thank you for the feedback @Prajyot-Parab and @mkumatag! |
What this PR does / why we need it:
Update controller-runtime to v0.15.0, which is a requirement for using this provider with Kube 1.27.
This is needed since kubernetes-sigs/cluster-api#8007 , which is now based
on that controller-runtime as well.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Part of kubernetes-sigs/cluster-api#8459
Part of https://issues.redhat.com/browse/SDN-3901
Special notes for your reviewer:
/area provider/ibmcloud
Release note: